issue_comments

Thanks @dcherian and @shoyer for the review and advice! It seems the docs build and the checks are fine now. One more thing, as this is my first PR to xarray: Should I merge/rebase master into the allow_invalid_netcdf branch, or will you guys take it from this point?

Hey guys, I'd like to move this forward, but the doc build failed with the message below.

• Do I need to add something specific to make the docs build?
• Do I need to do anything else to get this PR merged?

Thanks!

``` python

---

Exception in /home/vsts/work/1/s/doc/io.rst at block ending on line 388 Specify :okexcept: as an option in the ipython:: block to suppress this message

ModuleNotFoundError Traceback (most recent call last) <ipython-input-17-9100cd49113c> in <module> ----> 1 da.to_netcdf("complex.nc", engine="h5netcdf", invalid_netcdf=True)

~/work/1/s/xarray/core/dataarray.py in to_netcdf(self, args, kwargs) 2214 dataset = self.to_dataset() 2215 -> 2216 return dataset.to_netcdf(args, **kwargs) 2217 2218 def to_dict(self, data: bool = True) -> dict:

~/work/1/s/xarray/core/dataset.py in to_netcdf(self, path, mode, format, group, engine, encoding, unlimited_dims, compute, invalid_netcdf) 1519 unlimited_dims=unlimited_dims, 1520 compute=compute, -> 1521 invalid_netcdf=invalid_netcdf, 1522 ) 1523

~/work/1/s/xarray/backends/api.py in to_netcdf(dataset, path_or_file, mode, format, group, engine, encoding, unlimited_dims, compute, multifile, invalid_netcdf) 1052 "unrecognized option 'invalid_netcdf' for engine %s" % engine 1053 ) -> 1054 store = store_open(target, mode, format, group, **kwargs) 1055 1056 if unlimited_dims is None:

~/work/1/s/xarray/backends/h5netcdf_.py in init(self, filename, mode, format, group, lock, autoclose, invalid_netcdf) 81 invalid_netcdf=None, 82 ): ---> 83 import h5netcdf 84 85 if format not in [None, "NETCDF4"]:

ModuleNotFoundError: No module named 'h5netcdf' <<<-------------------------------------------------------------------------

/home/vsts/work/1/s/xarray/core/dataarray.py:docstring of xarray.DataArray.integrate:12: WARNING: Unexpected indentation. /home/vsts/work/1/s/xarray/core/dataarray.py:docstring of xarray.DataArray.interp:20: WARNING: Inline strong start-string without end-string. /home/vsts/work/1/s/xarray/core/dataarray.py:docstring of xarray.DataArray.interpolate_na:8: WARNING: Definition list ends without a blank line; unexpected unindent.

Sphinx parallel build error: RuntimeError: Non Expected exception in /home/vsts/work/1/s/doc/io.rst line 388

[error]The operation was canceled.

```

Hmm, seems like I broke the docs somehow... I someone could advice me how to fix? Thanks!

This will also need a note in whats-new.rst and a note in io.rst, perhaps under "Writing encoded data"

Sure, I'll add that when we are happy with the code and tests!