issue_comments

Table actions

7 rows where issue = 467862319 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Feature/2885 broadcast like · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
511232700 https://github.com/pydata/xarray/pull/3127#issuecomment-511232700 https://api.github.com/repos/pydata/xarray/issues/3127 MDEyOklzc3VlQ29tbWVudDUxMTIzMjcwMA== shoyer 1217238 2019-07-14T20:25:35Z 2019-07-14T20:25:35Z MEMBER

OK, I just merged https://github.com/pydata/xarray/pull/3086 in master.

I would suggest either merging master into this PR branch, or (probably easier) making a new branch from master with your improved docs/tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/2885 broadcast like 467862319
511232692 https://github.com/pydata/xarray/pull/3127#issuecomment-511232692 https://api.github.com/repos/pydata/xarray/issues/3127 MDEyOklzc3VlQ29tbWVudDUxMTIzMjY5Mg== DavidMertz 2380665 2019-07-14T20:25:27Z 2019-07-14T20:25:27Z CONTRIBUTOR

Great. Will do.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/2885 broadcast like 467862319
511232392 https://github.com/pydata/xarray/pull/3127#issuecomment-511232392 https://api.github.com/repos/pydata/xarray/issues/3127 MDEyOklzc3VlQ29tbWVudDUxMTIzMjM5Mg== shoyer 1217238 2019-07-14T20:20:54Z 2019-07-14T20:20:54Z MEMBER

I think I'm going to merge the other PR, then you can fork off of master again and add your doc/test improvements?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/2885 broadcast like 467862319
511232137 https://github.com/pydata/xarray/pull/3127#issuecomment-511232137 https://api.github.com/repos/pydata/xarray/issues/3127 MDEyOklzc3VlQ29tbWVudDUxMTIzMjEzNw== DavidMertz 2380665 2019-07-14T20:17:22Z 2019-07-14T20:17:22Z CONTRIBUTOR

I realized the overlap only after I made the PR. Their implementation of factoring out the shared code is better than my simple wrapper. But my documention and tests are better.

What's the best way to merge the best? I'm happy to do it, but not sure if it should be a new branch and PR, or a revision of one of the existing ones.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/2885 broadcast like 467862319
511229439 https://github.com/pydata/xarray/pull/3127#issuecomment-511229439 https://api.github.com/repos/pydata/xarray/issues/3127 MDEyOklzc3VlQ29tbWVudDUxMTIyOTQzOQ== shoyer 1217238 2019-07-14T19:36:31Z 2019-07-14T19:36:31Z MEMBER

Hi @DavidMertz -- @dcherian already started working on this over in https://github.com/pydata/xarray/pull/3086. But there's probably something useful that could be combined between these pull requests, maybe some of the docs or tests?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/2885 broadcast like 467862319
511219191 https://github.com/pydata/xarray/pull/3127#issuecomment-511219191 https://api.github.com/repos/pydata/xarray/issues/3127 MDEyOklzc3VlQ29tbWVudDUxMTIxOTE5MQ== codecov[bot] 22429695 2019-07-14T17:05:28Z 2019-07-14T17:17:05Z NONE

Codecov Report

Merging #3127 into master will increase coverage by 0.01%. The diff coverage is 88.88%.

```diff @@ Coverage Diff @@

master #3127 +/-

========================================== + Coverage 95.98% 95.99% +0.01%
========================================== Files 63 63
Lines 12777 12784 +7
========================================== + Hits 12264 12272 +8
+ Misses 513 512 -1 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/2885 broadcast like 467862319
511219382 https://github.com/pydata/xarray/pull/3127#issuecomment-511219382 https://api.github.com/repos/pydata/xarray/issues/3127 MDEyOklzc3VlQ29tbWVudDUxMTIxOTM4Mg== DavidMertz 2380665 2019-07-14T17:08:15Z 2019-07-14T17:08:15Z CONTRIBUTOR

This was branched off of https://github.com/pydata/xarray/pull/3127 by mistake. If both are merged, no issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/2885 broadcast like 467862319

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);