issue_comments: 511232137
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/3127#issuecomment-511232137 | https://api.github.com/repos/pydata/xarray/issues/3127 | 511232137 | MDEyOklzc3VlQ29tbWVudDUxMTIzMjEzNw== | 2380665 | 2019-07-14T20:17:22Z | 2019-07-14T20:17:22Z | CONTRIBUTOR | I realized the overlap only after I made the PR. Their implementation of factoring out the shared code is better than my simple wrapper. But my documention and tests are better. What's the best way to merge the best? I'm happy to do it, but not sure if it should be a new branch and PR, or a revision of one of the existing ones. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
467862319 |