issue_comments
9 rows where issue = 467856527 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- Return immutable view of Pandas indexes · 9 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
512058648 | https://github.com/pydata/xarray/pull/3126#issuecomment-512058648 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMjA1ODY0OA== | max-sixty 5635139 | 2019-07-17T00:56:58Z | 2019-07-17T00:56:58Z | MEMBER | Do you have an accidental binary file in the commit? https://github.com/pydata/xarray/pull/3126/files#diff-337006a573a2971594e829114137f91b |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
512031393 | https://github.com/pydata/xarray/pull/3126#issuecomment-512031393 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMjAzMTM5Mw== | gwgundersen 2818208 | 2019-07-16T22:50:04Z | 2019-07-16T22:50:04Z | CONTRIBUTOR | Okay, a couple changes to the original PR: we now perform a shallow copy of the returned index in This seems pretty robust: ```python
Since a ```python
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
512027994 | https://github.com/pydata/xarray/pull/3126#issuecomment-512027994 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMjAyNzk5NA== | max-sixty 5635139 | 2019-07-16T22:36:51Z | 2019-07-16T22:36:51Z | MEMBER |
Is there a reasonable way of making that immutable? Given that the index allows its name to be mutated, I'm not sure. (we can also separate that issue from this change, which is already 👍 ) |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
511214715 | https://github.com/pydata/xarray/pull/3126#issuecomment-511214715 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMTIxNDcxNQ== | pep8speaks 24736507 | 2019-07-14T16:02:51Z | 2019-07-16T22:33:30Z | NONE | Hello @gwgundersen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: Comment last updated at 2019-07-16 22:33:30 UTC |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
511216252 | https://github.com/pydata/xarray/pull/3126#issuecomment-511216252 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMTIxNjI1Mg== | codecov[bot] 22429695 | 2019-07-14T16:23:30Z | 2019-07-16T22:33:26Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ master #3126 +/-==========================================
- Coverage 95.99% 95.08% -0.92% |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
511716413 | https://github.com/pydata/xarray/pull/3126#issuecomment-511716413 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMTcxNjQxMw== | gwgundersen 2818208 | 2019-07-16T08:20:34Z | 2019-07-16T08:21:07Z | CONTRIBUTOR | Locally, I've moved my changes from @shoyer, it seems like this issue happens anywhere the user can modify a Pandas index. For example, the Dataset bug in my comment yesterday. Do we want all views of indexes to be immutable or do we trust the user to not do stuff like this: ```python
|
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
511523854 | https://github.com/pydata/xarray/pull/3126#issuecomment-511523854 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMTUyMzg1NA== | max-sixty 5635139 | 2019-07-15T18:48:26Z | 2019-07-15T18:48:26Z | MEMBER |
Thanks for finding that. That sounds right - if we make these changes there then I think we've solved the problem at its root and we should fix all these cases? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
511506569 | https://github.com/pydata/xarray/pull/3126#issuecomment-511506569 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMTUwNjU2OQ== | gwgundersen 2818208 | 2019-07-15T17:59:23Z | 2019-07-15T17:59:23Z | CONTRIBUTOR | @max-sixty, ```python
But you're right that ```python
Does anyone know if |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 | |
511451574 | https://github.com/pydata/xarray/pull/3126#issuecomment-511451574 | https://api.github.com/repos/pydata/xarray/issues/3126 | MDEyOklzc3VlQ29tbWVudDUxMTQ1MTU3NA== | max-sixty 5635139 | 2019-07-15T15:32:09Z | 2019-07-15T15:32:09Z | MEMBER | I don't quite understand why the previous constructor was returning a mutable view, but the tests look great. @gwgundersen do you know if we should instead be changing the Any other comments from anyone? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Return immutable view of Pandas indexes 467856527 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 4