home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 511716413

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3126#issuecomment-511716413 https://api.github.com/repos/pydata/xarray/issues/3126 511716413 MDEyOklzc3VlQ29tbWVudDUxMTcxNjQxMw== 2818208 2019-07-16T08:20:34Z 2019-07-16T08:21:07Z CONTRIBUTOR

Locally, I've moved my changes from DataArray.to_series to DataWithCoords.get_index, and my tests still pass. After work, I'll write some more tests, e.g. for for DataArray.to_index, and push.

@shoyer, it seems like this issue happens anywhere the user can modify a Pandas index. For example, the Dataset bug in my comment yesterday. Do we want all views of indexes to be immutable or do we trust the user to not do stuff like this:

```python

dataset.indexes['mutable?'].name = 'yes' dataset.indexes['mutable?'].name 'yes' ```

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  467856527
Powered by Datasette · Queries took 0.623ms · About: xarray-datasette