issue_comments

Table actions

5 rows where issue = 460562436 and user = 46687291 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • jukent · 5 ✖

issue 1

  • Added rename_coords and rename_dims · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
505611145 https://github.com/pydata/xarray/pull/3042#issuecomment-505611145 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTYxMTE0NQ== jukent 46687291 2019-06-25T20:32:33Z 2019-06-25T20:32:33Z CONTRIBUTOR

@jukent check out the existing rename tests here (they're a bit over-complicated at the beginning): https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2046-L2130

You could do something as simple as this: https://github.com/pydata/xarray/blob/master/xarray/tests/test_dataset.py#L2114-L2119 - i.e. start with a dataset, call a rename method, and compare the dataset with a manually constructed version of the expected result.

Ping back with any issues

Thanks @max-sixty. I added some very simple tests. I might copy more of the test_rename functions (if I tried to rename a variable to the same name for example)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505599777 https://github.com/pydata/xarray/pull/3042#issuecomment-505599777 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTU5OTc3Nw== jukent 46687291 2019-06-25T20:00:01Z 2019-06-25T20:00:01Z CONTRIBUTOR

3026

There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.

Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.

This works now! But to do so I created three different renaming variable helper functions (var name only, var and dims, var dims only). I will clean this up since the majority of these three functions is the same.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505598969 https://github.com/pydata/xarray/pull/3042#issuecomment-505598969 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTU5ODk2OQ== jukent 46687291 2019-06-25T19:57:36Z 2019-06-25T19:57:36Z CONTRIBUTOR

And tbc, we should add tests here. That will help clarify the issues above re exactly which items on the dataset each method should rename vs leave.

Yes I need to add tests, but I don't have much experience with this yet. I will ask my team here to help me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505587938 https://github.com/pydata/xarray/pull/3042#issuecomment-505587938 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTU4NzkzOA== jukent 46687291 2019-06-25T19:26:43Z 2019-06-25T19:26:43Z CONTRIBUTOR

3026

There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.

Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436
505569846 https://github.com/pydata/xarray/pull/3042#issuecomment-505569846 https://api.github.com/repos/pydata/xarray/issues/3042 MDEyOklzc3VlQ29tbWVudDUwNTU2OTg0Ng== jukent 46687291 2019-06-25T18:38:25Z 2019-06-25T18:38:25Z CONTRIBUTOR

pydata#3026

There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Added rename_coords and rename_dims 460562436

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);