issue_comments: 505599777

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3042#issuecomment-505599777 https://api.github.com/repos/pydata/xarray/issues/3042 505599777 MDEyOklzc3VlQ29tbWVudDUwNTU5OTc3Nw== 46687291 2019-06-25T20:00:01Z 2019-06-25T20:00:01Z CONTRIBUTOR

3026

There is some unexpected behavior. The new rename_dims function does not change the dimensions of the variables. Working on this now.

Similarly rename_vars will rename the variable dimensions and variables, but not the dataset dimensions. I thought I was dealing with this with the _rename_indexes. But will have to keep working.

This works now! But to do so I created three different renaming variable helper functions (var name only, var and dims, var dims only). I will clean this up since the majority of these three functions is the same.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   460562436