issue_comments

Table actions

3 rows where issue = 457716471 and user = 23738400 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • OriolAbril · 3 ✖

issue 1

  • apply_ufunc should preemptively broadcast · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
503768609 https://github.com/pydata/xarray/issues/3032#issuecomment-503768609 https://api.github.com/repos/pydata/xarray/issues/3032 MDEyOklzc3VlQ29tbWVudDUwMzc2ODYwOQ== OriolAbril 23738400 2019-06-19T22:23:21Z 2019-06-19T22:23:21Z CONTRIBUTOR

@max-sixty Not at all, whatever is best. I actually opened the issue without being 100% it was one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc should preemptively broadcast 457716471
503675891 https://github.com/pydata/xarray/issues/3032#issuecomment-503675891 https://api.github.com/repos/pydata/xarray/issues/3032 MDEyOklzc3VlQ29tbWVudDUwMzY3NTg5MQ== OriolAbril 23738400 2019-06-19T18:25:14Z 2019-06-19T18:25:14Z CONTRIBUTOR

I'm trying to think whether there would be any performance cost there - i.e. are there any arrays where preemptive broadcasting would be both expensive and unnecessary?

Even if there were a performance cost (compared to the actual behaviour), it could be easily avoided by using all dims as input_core_dims couldn't it? IIUC, all dims should be broadcasted unless they are in input core dims, so it broadcasting could still be avoided without problem.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc should preemptively broadcast 457716471
503335417 https://github.com/pydata/xarray/issues/3032#issuecomment-503335417 https://api.github.com/repos/pydata/xarray/issues/3032 MDEyOklzc3VlQ29tbWVudDUwMzMzNTQxNw== OriolAbril 23738400 2019-06-18T22:28:20Z 2019-06-18T22:28:20Z CONTRIBUTOR

Then shouldn't a in the first example keep its original shape?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   apply_ufunc should preemptively broadcast 457716471

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);