issue_comments

Table actions

3 rows where issue = 452734140 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • BUG: fix safe_cast_to_index · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
499273308 https://github.com/pydata/xarray/pull/3001#issuecomment-499273308 https://api.github.com/repos/pydata/xarray/issues/3001 MDEyOklzc3VlQ29tbWVudDQ5OTI3MzMwOA== pep8speaks 24736507 2019-06-05T22:07:03Z 2019-06-06T18:11:58Z NONE

Hello @0x0L! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-06-06 18:11:58 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: fix safe_cast_to_index 452734140
499600988 https://github.com/pydata/xarray/pull/3001#issuecomment-499600988 https://api.github.com/repos/pydata/xarray/issues/3001 MDEyOklzc3VlQ29tbWVudDQ5OTYwMDk4OA== spencerkclark 6628425 2019-06-06T17:55:22Z 2019-06-06T17:55:22Z MEMBER

Are you ok with keeping the len > 0 test and then just moving up the assert at the top of the constructor of CFTimeIndex so that we raise before allocating the memory with result._data = np.array(data, dtype='O')

Yes, sorry, it seems I'm a bit sleepy today as well. This is probably the best approach 👍.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: fix safe_cast_to_index 452734140
499598244 https://github.com/pydata/xarray/pull/3001#issuecomment-499598244 https://api.github.com/repos/pydata/xarray/issues/3001 MDEyOklzc3VlQ29tbWVudDQ5OTU5ODI0NA== 0x0L 3621629 2019-06-06T17:47:36Z 2019-06-06T17:47:36Z CONTRIBUTOR

@spencerkclark Are you ok with keeping the len > 0 test and then just moving up the assert at the top of the constructor of CFTimeIndex so that we raise before allocating the memory with result._data = np.array(data, dtype='O')

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: fix safe_cast_to_index 452734140

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);