issue_comments: 499600988

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3001#issuecomment-499600988 https://api.github.com/repos/pydata/xarray/issues/3001 499600988 MDEyOklzc3VlQ29tbWVudDQ5OTYwMDk4OA== 6628425 2019-06-06T17:55:22Z 2019-06-06T17:55:22Z MEMBER

Are you ok with keeping the len > 0 test and then just moving up the assert at the top of the constructor of CFTimeIndex so that we raise before allocating the memory with result._data = np.array(data, dtype='O')

Yes, sorry, it seems I'm a bit sleepy today as well. This is probably the best approach 👍.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   452734140