issue_comments

Table actions

7 rows where issue = 448295143 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Implement @ operator for DataArray · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
497971124 https://github.com/pydata/xarray/pull/2987#issuecomment-497971124 https://api.github.com/repos/pydata/xarray/issues/2987 MDEyOklzc3VlQ29tbWVudDQ5Nzk3MTEyNA== max-sixty 5635139 2019-06-01T19:23:03Z 2019-06-01T19:23:03Z MEMBER

LMK if good to merge!

(coming from the person with a terrible record of finishing PRs... 😉 )

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement @ operator for DataArray 448295143
496971365 https://github.com/pydata/xarray/pull/2987#issuecomment-496971365 https://api.github.com/repos/pydata/xarray/issues/2987 MDEyOklzc3VlQ29tbWVudDQ5Njk3MTM2NQ== max-sixty 5635139 2019-05-29T14:52:49Z 2019-05-29T14:52:49Z MEMBER

Great - I added rmatmul and a v short example in the basic-array-math section. LMK if good to merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement @ operator for DataArray 448295143
495738823 https://github.com/pydata/xarray/pull/2987#issuecomment-495738823 https://api.github.com/repos/pydata/xarray/issues/2987 MDEyOklzc3VlQ29tbWVudDQ5NTczODgyMw== pep8speaks 24736507 2019-05-24T18:14:25Z 2019-05-29T14:52:29Z NONE

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-05-29 14:52:29 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement @ operator for DataArray 448295143
496667122 https://github.com/pydata/xarray/pull/2987#issuecomment-496667122 https://api.github.com/repos/pydata/xarray/issues/2987 MDEyOklzc3VlQ29tbWVudDQ5NjY2NzEyMg== shoyer 1217238 2019-05-28T20:01:50Z 2019-05-28T20:01:50Z MEMBER

It might be worth using @ instead of dot() in the docs in a few places, but I don't think it's essential to mention it specifically.

On Tue, May 28, 2019 at 12:36 PM Deepak Cherian notifications@github.com wrote:

Do we need a line here? https://xarray.pydata.org/en/stable/computation.html#basic-array-math

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2987?email_source=notifications&email_token=AAJJFVSCWZ33XTE7H3E4ZVTPXWCU5A5CNFSM4HPRVPKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNGOWY#issuecomment-496658267, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVSF7FRXQEBS7IB6EQTPXWCU5ANCNFSM4HPRVPKA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement @ operator for DataArray 448295143
496658267 https://github.com/pydata/xarray/pull/2987#issuecomment-496658267 https://api.github.com/repos/pydata/xarray/issues/2987 MDEyOklzc3VlQ29tbWVudDQ5NjY1ODI2Nw== dcherian 2448579 2019-05-28T19:36:45Z 2019-05-28T19:36:45Z MEMBER 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement @ operator for DataArray 448295143
496635695 https://github.com/pydata/xarray/pull/2987#issuecomment-496635695 https://api.github.com/repos/pydata/xarray/issues/2987 MDEyOklzc3VlQ29tbWVudDQ5NjYzNTY5NQ== shoyer 1217238 2019-05-28T18:31:03Z 2019-05-28T18:31:03Z MEMBER

This looks good to me!

In general, it's a good idea to also define reflexive methods, e.g., __rmatmul__ in this case. But I'm not sure we actually need that, given that dot only supports operations with xarray.DataArray at present.

I guess this could be useful for people writing subclasses, or other objects that override arithmetic with xarray objects. So you might as well add something like: def __rmatmul__(self, other): return xarray.dot(other, dot)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement @ operator for DataArray 448295143
496568423 https://github.com/pydata/xarray/pull/2987#issuecomment-496568423 https://api.github.com/repos/pydata/xarray/issues/2987 MDEyOklzc3VlQ29tbWVudDQ5NjU2ODQyMw== max-sixty 5635139 2019-05-28T15:32:29Z 2019-05-28T15:32:29Z MEMBER

Any thoughts, team?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement @ operator for DataArray 448295143

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);