issue_comments: 496635695

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2987#issuecomment-496635695 https://api.github.com/repos/pydata/xarray/issues/2987 496635695 MDEyOklzc3VlQ29tbWVudDQ5NjYzNTY5NQ== 1217238 2019-05-28T18:31:03Z 2019-05-28T18:31:03Z MEMBER

This looks good to me!

In general, it's a good idea to also define reflexive methods, e.g., __rmatmul__ in this case. But I'm not sure we actually need that, given that dot only supports operations with xarray.DataArray at present.

I guess this could be useful for people writing subclasses, or other objects that override arithmetic with xarray objects. So you might as well add something like: def __rmatmul__(self, other): return xarray.dot(other, dot)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   448295143