issue_comments

Table actions

3 rows where issue = 447361330 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • cbar_kwargs are ignored for `plot.contourf` · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
495275980 https://github.com/pydata/xarray/issues/2982#issuecomment-495275980 https://api.github.com/repos/pydata/xarray/issues/2982 MDEyOklzc3VlQ29tbWVudDQ5NTI3NTk4MA== dcherian 2448579 2019-05-23T15:49:04Z 2019-05-23T15:49:32Z MEMBER

Yes looks like _add_colorbar in plot/utils.py works around this :) in this line: cbar_kwargs.setdefault('extend', cmap_params['extend'])

Now I'm confused why your initial statement didn't work.

It's a little funny because _determine_cmap_params autosets extend based on vmin, vmax. I think you should be able to modify _process_cmap_... to do the right thing so that cmap_params needn't be provided to _add_colorbar in _plot2d.

I agree extend is really a cbar_kwarg. Can you send in a PR to fix this?

By do the right thing I mean move extend to cbar_kwargs

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cbar_kwargs are ignored for `plot.contourf` 447361330
495011402 https://github.com/pydata/xarray/issues/2982#issuecomment-495011402 https://api.github.com/repos/pydata/xarray/issues/2982 MDEyOklzc3VlQ29tbWVudDQ5NTAxMTQwMg== jbusecke 14314623 2019-05-22T23:28:41Z 2019-05-22T23:28:41Z CONTRIBUTOR

If I understand correctly then it gets piped through cmap_kwargs, which seems odd to me. Do you agree that this is a bug? Or am I missing a case where it would be preferable to pass extend directly to plot.contourf?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cbar_kwargs are ignored for `plot.contourf` 447361330
494996134 https://github.com/pydata/xarray/issues/2982#issuecomment-494996134 https://api.github.com/repos/pydata/xarray/issues/2982 MDEyOklzc3VlQ29tbWVudDQ5NDk5NjEzNA== dcherian 2448579 2019-05-22T22:22:02Z 2019-05-22T22:22:02Z MEMBER

If you pass extend='neither' directly it should work. There is a _process_cmap_params_cbar_kwargs in plot/utils.py (I think) that deals with this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   cbar_kwargs are ignored for `plot.contourf` 447361330

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);