issue_comments: 495275980

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2982#issuecomment-495275980 https://api.github.com/repos/pydata/xarray/issues/2982 495275980 MDEyOklzc3VlQ29tbWVudDQ5NTI3NTk4MA== 2448579 2019-05-23T15:49:04Z 2019-05-23T15:49:32Z MEMBER

Yes looks like _add_colorbar in plot/utils.py works around this :) in this line: cbar_kwargs.setdefault('extend', cmap_params['extend'])

Now I'm confused why your initial statement didn't work.

It's a little funny because _determine_cmap_params autosets extend based on vmin, vmax. I think you should be able to modify _process_cmap_... to do the right thing so that cmap_params needn't be provided to _add_colorbar in _plot2d.

I agree extend is really a cbar_kwarg. Can you send in a PR to fix this?

By do the right thing I mean move extend to cbar_kwargs

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   447361330