issue_comments

Table actions

7 rows where issue = 444510710 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Add fill_value for concat and auto_combine · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
496043263 https://github.com/pydata/xarray/pull/2964#issuecomment-496043263 https://api.github.com/repos/pydata/xarray/issues/2964 MDEyOklzc3VlQ29tbWVudDQ5NjA0MzI2Mw== shoyer 1217238 2019-05-27T00:21:02Z 2019-05-27T00:21:02Z MEMBER

Thanks @zdgriffith !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add fill_value for concat and auto_combine 444510710
494514343 https://github.com/pydata/xarray/pull/2964#issuecomment-494514343 https://api.github.com/repos/pydata/xarray/issues/2964 MDEyOklzc3VlQ29tbWVudDQ5NDUxNDM0Mw== shoyer 1217238 2019-05-21T18:54:22Z 2019-05-21T18:54:22Z MEMBER

Just to be totally explicit then changing _auto_combine() obviously means that open_mfdataset() will have an implicit default kwarg fill_value='dtypes.NA', but if that's always the desired behaviour then that's fine.

This is the current default behavior for open_mfdataset. We could potentially had a fill_value option there, too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add fill_value for concat and auto_combine 444510710
494512015 https://github.com/pydata/xarray/pull/2964#issuecomment-494512015 https://api.github.com/repos/pydata/xarray/issues/2964 MDEyOklzc3VlQ29tbWVudDQ5NDUxMjAxNQ== TomNicholas 35968931 2019-05-21T18:47:38Z 2019-05-21T18:47:53Z MEMBER

Yeah this looks fine to me - it basically bypasses all the complicated combining logic anyway.

Just to be totally explicit then changing _auto_combine() obviously means that open_mfdataset() will have an implicit default kwarg fill_value='dtypes.NA', but if that's always the desired behaviour then that's fine.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add fill_value for concat and auto_combine 444510710
494488275 https://github.com/pydata/xarray/pull/2964#issuecomment-494488275 https://api.github.com/repos/pydata/xarray/issues/2964 MDEyOklzc3VlQ29tbWVudDQ5NDQ4ODI3NQ== shoyer 1217238 2019-05-21T17:39:48Z 2019-05-21T17:39:48Z MEMBER

This looks pretty safe to me. It's basically just threading down the fill_value argument.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add fill_value for concat and auto_combine 444510710
494471201 https://github.com/pydata/xarray/pull/2964#issuecomment-494471201 https://api.github.com/repos/pydata/xarray/issues/2964 MDEyOklzc3VlQ29tbWVudDQ5NDQ3MTIwMQ== dcherian 2448579 2019-05-21T16:50:54Z 2019-05-21T16:50:54Z MEMBER

:+1:. Mind giving this PR a review? You know this bit of the code well...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add fill_value for concat and auto_combine 444510710
494468833 https://github.com/pydata/xarray/pull/2964#issuecomment-494468833 https://api.github.com/repos/pydata/xarray/issues/2964 MDEyOklzc3VlQ29tbWVudDQ5NDQ2ODgzMw== TomNicholas 35968931 2019-05-21T16:43:56Z 2019-05-21T16:43:56Z MEMBER

Yeah I saw this - that's fine. Probably best to do them as separate commits though no? Just depends which one gets merged first. If we merge mine first then I'm happy to review/adapt this PR to be compatible. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add fill_value for concat and auto_combine 444510710
494467365 https://github.com/pydata/xarray/pull/2964#issuecomment-494467365 https://api.github.com/repos/pydata/xarray/issues/2964 MDEyOklzc3VlQ29tbWVudDQ5NDQ2NzM2NQ== dcherian 2448579 2019-05-21T16:39:44Z 2019-05-21T16:39:44Z MEMBER

@TomNicholas looks like you'll need to add fill_value to combine_auto and combine_manual?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add fill_value for concat and auto_combine 444510710

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);