home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 494512015

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2964#issuecomment-494512015 https://api.github.com/repos/pydata/xarray/issues/2964 494512015 MDEyOklzc3VlQ29tbWVudDQ5NDUxMjAxNQ== 35968931 2019-05-21T18:47:38Z 2019-05-21T18:47:53Z MEMBER

Yeah this looks fine to me - it basically bypasses all the complicated combining logic anyway.

Just to be totally explicit then changing _auto_combine() obviously means that open_mfdataset() will have an implicit default kwarg fill_value='dtypes.NA', but if that's always the desired behaviour then that's fine.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  444510710
Powered by Datasette · Queries took 0.669ms · About: xarray-datasette