home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where issue = 439823329 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable · 3 ✖

author_association 1

  • MEMBER 3
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
490969141 https://github.com/pydata/xarray/pull/2936#issuecomment-490969141 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MDk2OTE0MQ== shoyer 1217238 2019-05-09T16:13:29Z 2019-05-09T16:13:29Z MEMBER

Don't worry about it, this happens. If you can't figure out an immediate fix, please just mark the tests as "xfail" so they don't block other PRs. I'm pretty sure the issue here is in the tests, not your fix.

On Thu, May 9, 2019 at 9:08 AM Martin Pletcher notifications@github.com wrote:

Sure. I'm looking into it now.

Sorry about that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2936#issuecomment-490967152, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVWYEUWLGSDKNURDUWTPURD6RANCNFSM4HKLQTTQ .

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
490964929 https://github.com/pydata/xarray/pull/2936#issuecomment-490964929 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MDk2NDkyOQ== shoyer 1217238 2019-05-09T16:02:07Z 2019-05-09T16:02:07Z MEMBER

It seems xarray (mistakenly?) relies on the immutability of index data somewhere else, and hence reuses the same pandas.Index object for data in both data and coords.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
490963840 https://github.com/pydata/xarray/pull/2936#issuecomment-490963840 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MDk2Mzg0MA== shoyer 1217238 2019-05-09T15:59:03Z 2019-05-09T15:59:03Z MEMBER

Can you take a look at the test failures on Windows? These seem to be due to your charge: ``` ================================== FAILURES =================================== __ TestDataArray.test_copy_coords[False-expected_orig1] _____ self = <xarray.tests.test_dataarray.TestDataArray object at 0x000000AAE0637F28> deep = False expected_orig = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 @pytest.mark.parametrize('deep, expected_orig', [ [True, xr.DataArray(xr.IndexVariable('a', np.array([1, 2])), coords={'a': [1, 2]}, dims=['a'])], [False, xr.DataArray(xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a'])]]) def test_copy_coords(self, deep, expected_orig): da = xr.DataArray( np.ones([2, 2, 2]), coords={'a': [1, 2], 'b': ['x', 'y'], 'c': [0, 1]}, dims=['a', 'b', 'c']) da_cp = da.copy(deep) da_cp['a'].data[0] = 999

    expected_cp = xr.DataArray(
        xr.IndexVariable('a', np.array([999, 2])),
        coords={'a': [999, 2]}, dims=['a'])
  assert_identical(da_cp['a'], expected_cp)

xarray\tests\test_dataarray.py:3342:


a = <xarray.DataArray 'a' (a: 2)> array([1, 2]) Coordinates: * a (a) int32 1 2 b = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 def assert_identical(a, b):

  xarray.testing.assert_identical(a, b)

E AssertionError: Left and right DataArray objects are not identical E
E Differing values: E L E array([1, 2]) E R E array([999, 2]) E Differing coordinates: E L * a (a) int32 1 2 E R * a (a) int32 999 2 xarray\tests__init__.py:195: AssertionError ___ TestDataset.test_copy_coords[False-expected_orig1] ______ self = <xarray.tests.test_dataset.TestDataset object at 0x000000AAE05256A0> deep = False expected_orig = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 @pytest.mark.parametrize('deep, expected_orig', [ [True, xr.DataArray(xr.IndexVariable('a', np.array([1, 2])), coords={'a': [1, 2]}, dims=['a'])], [False, xr.DataArray(xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a'])]]) def test_copy_coords(self, deep, expected_orig): ds = xr.DataArray( np.ones([2, 2, 2]), coords={'a': [1, 2], 'b': ['x', 'y'], 'c': [0, 1]}, dims=['a', 'b', 'c'], name='value').to_dataset() ds_cp = ds.copy(deep=deep) ds_cp.coords['a'].data[0] = 999

    expected_cp = xr.DataArray(
        xr.IndexVariable('a', np.array([999, 2])),
        coords={'a': [999, 2]}, dims=['a'])
  assert_identical(ds_cp.coords['a'], expected_cp)

xarray\tests\test_dataset.py:1993:


a = <xarray.DataArray 'a' (a: 2)> array([1, 2]) Coordinates: * a (a) int32 1 2 b = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 def assert_identical(a, b):

  xarray.testing.assert_identical(a, b)

E AssertionError: Left and right DataArray objects are not identical E
E Differing values: E L E array([1, 2]) E R E array([999, 2]) E Differing coordinates: E L * a (a) int32 1 2 E R * a (a) int32 999 2 xarray\tests__init__.py:195: AssertionError ============================== warnings summary =============================== ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 190.87ms · About: xarray-datasette