issue_comments: 490963840

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2936#issuecomment-490963840 https://api.github.com/repos/pydata/xarray/issues/2936 490963840 MDEyOklzc3VlQ29tbWVudDQ5MDk2Mzg0MA== 1217238 2019-05-09T15:59:03Z 2019-05-09T15:59:03Z MEMBER

Can you take a look at the test failures on Windows? These seem to be due to your charge: ``` ================================== FAILURES =================================== __ TestDataArray.test_copy_coords[False-expected_orig1] _____ self = <xarray.tests.test_dataarray.TestDataArray object at 0x000000AAE0637F28> deep = False expected_orig = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 @pytest.mark.parametrize('deep, expected_orig', [ [True, xr.DataArray(xr.IndexVariable('a', np.array([1, 2])), coords={'a': [1, 2]}, dims=['a'])], [False, xr.DataArray(xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a'])]]) def test_copy_coords(self, deep, expected_orig): da = xr.DataArray( np.ones([2, 2, 2]), coords={'a': [1, 2], 'b': ['x', 'y'], 'c': [0, 1]}, dims=['a', 'b', 'c']) da_cp = da.copy(deep) da_cp['a'].data[0] = 999

    expected_cp = xr.DataArray(
        xr.IndexVariable('a', np.array([999, 2])),
        coords={'a': [999, 2]}, dims=['a'])

  assert_identical(da_cp['a'], expected_cp)

xarray\tests\test_dataarray.py:3342:

a = <xarray.DataArray 'a' (a: 2)> array([1, 2]) Coordinates: * a (a) int32 1 2 b = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 def assert_identical(a, b):

  xarray.testing.assert_identical(a, b)

E AssertionError: Left and right DataArray objects are not identical E
E Differing values: E L E array([1, 2]) E R E array([999, 2]) E Differing coordinates: E L * a (a) int32 1 2 E R * a (a) int32 999 2 xarray\tests__init__.py:195: AssertionError ___ TestDataset.test_copy_coords[False-expected_orig1] ______ self = <xarray.tests.test_dataset.TestDataset object at 0x000000AAE05256A0> deep = False expected_orig = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 @pytest.mark.parametrize('deep, expected_orig', [ [True, xr.DataArray(xr.IndexVariable('a', np.array([1, 2])), coords={'a': [1, 2]}, dims=['a'])], [False, xr.DataArray(xr.IndexVariable('a', np.array([999, 2])), coords={'a': [999, 2]}, dims=['a'])]]) def test_copy_coords(self, deep, expected_orig): ds = xr.DataArray( np.ones([2, 2, 2]), coords={'a': [1, 2], 'b': ['x', 'y'], 'c': [0, 1]}, dims=['a', 'b', 'c'], name='value').to_dataset() ds_cp = ds.copy(deep=deep) ds_cp.coords['a'].data[0] = 999

    expected_cp = xr.DataArray(
        xr.IndexVariable('a', np.array([999, 2])),
        coords={'a': [999, 2]}, dims=['a'])

  assert_identical(ds_cp.coords['a'], expected_cp)

xarray\tests\test_dataset.py:1993:

a = <xarray.DataArray 'a' (a: 2)> array([1, 2]) Coordinates: * a (a) int32 1 2 b = <xarray.DataArray 'a' (a: 2)> array([999, 2]) Coordinates: * a (a) int32 999 2 def assert_identical(a, b):

  xarray.testing.assert_identical(a, b)

E AssertionError: Left and right DataArray objects are not identical E
E Differing values: E L E array([1, 2]) E R E array([999, 2]) E Differing coordinates: E L * a (a) int32 1 2 E R * a (a) int32 999 2 xarray\tests__init__.py:195: AssertionError ============================== warnings summary =============================== ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   439823329