issue_comments

Table actions

5 rows where issue = 439823329 and user = 10720577 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • pletchm · 5 ✖

issue 1

  • BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
491032096 https://github.com/pydata/xarray/pull/2936#issuecomment-491032096 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MTAzMjA5Ng== pletchm 10720577 2019-05-09T19:19:12Z 2019-05-09T19:19:12Z CONTRIBUTOR

@shoyer, I spent sometime looking into it and it looks like the test fails for the shallow copy, and apparently only on Windows for some reason. In Windows coords seem to be immutable unless it's one dataarray deep copied from another (which is why only the deep=False test fails). So I decided to just mark the tests as xfail for now (but I'd be happy to create an issue and look into it more in the future).

I'll open a new PR marking the tests with xfail shortly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
490967152 https://github.com/pydata/xarray/pull/2936#issuecomment-490967152 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ5MDk2NzE1Mg== pletchm 10720577 2019-05-09T16:08:07Z 2019-05-09T16:08:07Z CONTRIBUTOR

Sure. I'm looking into it now.

Sorry about that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
489878553 https://github.com/pydata/xarray/pull/2936#issuecomment-489878553 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ4OTg3ODU1Mw== pletchm 10720577 2019-05-07T02:07:14Z 2019-05-07T02:07:14Z CONTRIBUTOR

Yep, the tests are back now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
489818753 https://github.com/pydata/xarray/pull/2936#issuecomment-489818753 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ4OTgxODc1Mw== pletchm 10720577 2019-05-06T23:05:20Z 2019-05-06T23:05:20Z CONTRIBUTOR

@pletchm thanks for the PR!

I think the test failuers are dependencies rather than your changes! I kicked off a build of master here: https://travis-ci.org/pydata/xarray/builds/524754660 to confirm - if it's the same failures then we'll know it's not this code

Thanks for looking into this, @max-sixty! It looks like the errors are the same, so the problem is dependencies, right? How do we go about fixing that?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329
488862083 https://github.com/pydata/xarray/pull/2936#issuecomment-488862083 https://api.github.com/repos/pydata/xarray/issues/2936 MDEyOklzc3VlQ29tbWVudDQ4ODg2MjA4Mw== pletchm 10720577 2019-05-02T23:00:07Z 2019-05-02T23:00:07Z CONTRIBUTOR

Tests and documentation forthcoming. I had already opened a PR, but was perplexed when the build and tests weren't passing -- suspected it was related to my commits.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUGFIX: deep-copy wasn't copying coords, bug fixed within IndexVariable 439823329

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);