home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 491032096

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2936#issuecomment-491032096 https://api.github.com/repos/pydata/xarray/issues/2936 491032096 MDEyOklzc3VlQ29tbWVudDQ5MTAzMjA5Ng== 10720577 2019-05-09T19:19:12Z 2019-05-09T19:19:12Z CONTRIBUTOR

@shoyer, I spent sometime looking into it and it looks like the test fails for the shallow copy, and apparently only on Windows for some reason. In Windows coords seem to be immutable unless it's one dataarray deep copied from another (which is why only the deep=False test fails). So I decided to just mark the tests as xfail for now (but I'd be happy to create an issue and look into it more in the future).

I'll open a new PR marking the tests with xfail shortly.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  439823329
Powered by Datasette · Queries took 2.941ms · About: xarray-datasette