issue_comments

Table actions

6 rows where issue = 437956917 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • fix multiIndex min max issue #2923 · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
506410362 https://github.com/pydata/xarray/pull/2924#issuecomment-506410362 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDUwNjQxMDM2Mg== dcherian 2448579 2019-06-27T16:07:12Z 2019-06-27T16:07:12Z MEMBER

Thanks @arabidopsis. Welcome to xarray!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917
487297145 https://github.com/pydata/xarray/pull/2924#issuecomment-487297145 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDQ4NzI5NzE0NQ== pep8speaks 24736507 2019-04-27T15:53:19Z 2019-06-27T16:06:21Z NONE

Hello @arabidopsis! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-06-27 16:06:21 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917
487331380 https://github.com/pydata/xarray/pull/2924#issuecomment-487331380 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDQ4NzMzMTM4MA== shoyer 1217238 2019-04-28T01:08:08Z 2019-04-28T01:08:08Z MEMBER

Just a question. I put a guard in to test just for tuples (because that's what was breaking for me) but it seems to me that _nan_minmax_object should just return utils.to_0d_object_array(data) unconditionally at that point no? It's a max or a min right.

Wasn't sure.

Yes, it does seem like a good idea to just return utils.to_0d_object_array() unilaterally in this case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917
487329592 https://github.com/pydata/xarray/pull/2924#issuecomment-487329592 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDQ4NzMyOTU5Mg== arabidopsis 9948595 2019-04-28T00:21:15Z 2019-04-28T00:21:15Z CONTRIBUTOR

No problem. Thanks for xarray!

Just a question. I put a guard in to test just for tuples (because that's what was breaking for me) but it seems to me that _nan_minmax_object should just return utils.to_0d_object_array(data) unconditionally at that point no? It's a max or a min right.

Wasn't sure.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917
487325673 https://github.com/pydata/xarray/pull/2924#issuecomment-487325673 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDQ4NzMyNTY3Mw== shoyer 1217238 2019-04-27T22:53:12Z 2019-04-27T22:53:12Z MEMBER

Awesome, thank you @arabidopsis!

If you don't mind, it would be great if you could add a brief note about the bug fix to whats-new.rst. (if not, don't worry, I'll merge this in a few days either way)

You can ignore the test failure on Python 3.5. Something else seems to be going wrong there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917
487298047 https://github.com/pydata/xarray/pull/2924#issuecomment-487298047 https://api.github.com/repos/pydata/xarray/issues/2924 MDEyOklzc3VlQ29tbWVudDQ4NzI5ODA0Nw== arabidopsis 9948595 2019-04-27T16:04:45Z 2019-04-27T16:04:45Z CONTRIBUTOR

Oops... I usually use black -- which I turned off since it would really have stuffed the code :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix multiIndex min max issue #2923 437956917

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);