issue_comments: 487331380

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2924#issuecomment-487331380 https://api.github.com/repos/pydata/xarray/issues/2924 487331380 MDEyOklzc3VlQ29tbWVudDQ4NzMzMTM4MA== 1217238 2019-04-28T01:08:08Z 2019-04-28T01:08:08Z MEMBER

Just a question. I put a guard in to test just for tuples (because that's what was breaking for me) but it seems to me that _nan_minmax_object should just return utils.to_0d_object_array(data) unconditionally at that point no? It's a max or a min right.

Wasn't sure.

Yes, it does seem like a good idea to just return utils.to_0d_object_array() unilaterally in this case.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   437956917