issue_comments

Table actions

11 rows where issue = 437126178 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • DOC: avoid downloading .tif file · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
488999383 https://github.com/pydata/xarray/pull/2919#issuecomment-488999383 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4ODk5OTM4Mw== fmaussion 10050469 2019-05-03T08:11:58Z 2019-05-03T08:11:58Z MEMBER

How about adding a comment saying that this may/may not work and suggest a workaround

Thanks for the suggestion! I've decided against it because it will be too wordy - let's see if this is really affecting that many people first.

Thanks @grinsted for the PR!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
487636944 https://github.com/pydata/xarray/pull/2919#issuecomment-487636944 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NzYzNjk0NA== dcherian 2448579 2019-04-29T15:55:52Z 2019-04-29T15:55:52Z MEMBER

How about adding a comment saying that this may/may not work and suggest a workaround

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
487489532 https://github.com/pydata/xarray/pull/2919#issuecomment-487489532 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NzQ4OTUzMg== fmaussion 10050469 2019-04-29T08:22:47Z 2019-04-29T08:22:47Z MEMBER

I wonder why it desn't work with pip.

Because of that: https://github.com/mapbox/rasterio#ssl-certs . It will work, but not out-of-the box. I personally don't mind, but we might get a few "your example doesn't work" requests here although it has nothing to do with xarray, this is why I'm asking others devs before merging.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
487485638 https://github.com/pydata/xarray/pull/2919#issuecomment-487485638 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NzQ4NTYzOA== grinsted 2535390 2019-04-29T08:07:31Z 2019-04-29T08:07:31Z CONTRIBUTOR

I wonder why it desn't work with pip. It is a feature inherited from GDAL. I guess it has something to do with how that is compiled. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
487476404 https://github.com/pydata/xarray/pull/2919#issuecomment-487476404 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NzQ3NjQwNA== fmaussion 10050469 2019-04-29T07:28:36Z 2019-04-29T07:28:36Z MEMBER

Thanks! Yes, I've tested on a conda env and it works. So my take is that it probably won't work out-of-the box on debian/ubuntu/mint where rasterio is installed via pip.

So my question to @shoyer or @jhamman : should we change this example for the nicer code above, even if a minority of people (pip users like me) might find that this doesn't work for them?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
487469379 https://github.com/pydata/xarray/pull/2919#issuecomment-487469379 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NzQ2OTM3OQ== grinsted 2535390 2019-04-29T06:56:31Z 2019-04-29T06:56:31Z CONTRIBUTOR

I have just tested on a linux box and it works. I have access to a geo-notebook on a cloud service via my university . sys.version says:

3.6.7 | packaged by conda-forge | (default, Feb 28 2019, 09:07:38) [GCC 7.3.0]

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
487396945 https://github.com/pydata/xarray/pull/2919#issuecomment-487396945 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NzM5Njk0NQ== grinsted 2535390 2019-04-28T16:57:46Z 2019-04-28T16:57:46Z CONTRIBUTOR

I wrote this code on Windows 10. I also use the rasterio feature on a Linux box (but not via xarray). I use anaconda on both machines.

On Fri, 26 Apr 2019, 12:16 Fabien Maussion, notifications@github.com wrote:

@grinsted https://github.com/grinsted what OS are you running this on? I'm a bit concerned about this here: https://github.com/mapbox/rasterio#ssl-certs

I came into this while trying it locally, and even after setting the env variable I still get this error:

RasterioIOError: '/vsicurl/https://github.com/mapbox/rasterio/raw/master/tests/data/RGB.byte.tif' does not exist in the file system, and is not recognized as a supported dataset name.

I wonder if I'm the only one in that case, or if other users might be affected as well

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2919#issuecomment-487007098, or mute the thread https://github.com/notifications/unsubscribe-auth/AATK7XQJHYCK4TT7TILBSEDPSLJA3ANCNFSM4HIL2KYQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
487007098 https://github.com/pydata/xarray/pull/2919#issuecomment-487007098 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NzAwNzA5OA== fmaussion 10050469 2019-04-26T10:16:40Z 2019-04-26T10:16:40Z MEMBER

@grinsted what OS are you running this on? I'm a bit concerned about this here: https://github.com/mapbox/rasterio#ssl-certs

I came into this while trying it locally, and even after setting the env variable I still get this error:

RasterioIOError: '/vsicurl/https://github.com/mapbox/rasterio/raw/master/tests/data/RGB.byte.tif' does not exist in the file system, and is not recognized as a supported dataset name.

I wonder if I'm the only one in that case, or if other users might be affected as well

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
486618601 https://github.com/pydata/xarray/pull/2919#issuecomment-486618601 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NjYxODYwMQ== pep8speaks 24736507 2019-04-25T10:32:25Z 2019-04-26T09:44:24Z NONE

Hello @grinsted! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-26 09:44:24 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
486657353 https://github.com/pydata/xarray/pull/2919#issuecomment-486657353 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NjY1NzM1Mw== grinsted 2535390 2019-04-25T12:45:57Z 2019-04-25T12:45:57Z CONTRIBUTOR

Done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178
486619296 https://github.com/pydata/xarray/pull/2919#issuecomment-486619296 https://api.github.com/repos/pydata/xarray/issues/2919 MDEyOklzc3VlQ29tbWVudDQ4NjYxOTI5Ng== fmaussion 10050469 2019-04-25T10:34:58Z 2019-04-25T10:34:58Z MEMBER

Thanks! Can you do the same for the other example as well?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DOC: avoid downloading .tif file 437126178

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);