issue_comments: 487827162

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2917#issuecomment-487827162 https://api.github.com/repos/pydata/xarray/issues/2917 487827162 MDEyOklzc3VlQ29tbWVudDQ4NzgyNzE2Mg== 1217238 2019-04-30T05:43:49Z 2019-04-30T05:44:21Z MEMBER

Forgive me, I don't understand what you mean by download vs open. I see that tutorial.load_dataset() is different from this PR in that it keeps the file handle open instead of closing it. Is that the distinction you are referring to?

The difference I was referring to is that xarray.tutorial.load_dataset() needs to call xarray.tutorial.open_dataset() internally, not xarray.open_dataset(). But otherwise it can look exactly like xarray.load_dataset, e.g., it should be: ```python

in tutorial.py

def load_dataset(args, kwargs): # this calls tutorial.open_dataset, not xarray.open_dataset with open_dataset(args, **kwargs) as ds: return ds.load() ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   436999500