issue_comments

Table actions

8 rows where issue = 434502234 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

author_association 3

issue 1

  • Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
781406357 https://github.com/pydata/xarray/pull/2905#issuecomment-781406357 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDc4MTQwNjM1Nw== keewis 14808389 2021-02-18T15:04:02Z 2021-02-18T15:04:02Z MEMBER

thanks again, @blsqr

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
781160118 https://github.com/pydata/xarray/pull/2905#issuecomment-781160118 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDc4MTE2MDExOA== blsqr 1700203 2021-02-18T08:30:46Z 2021-02-18T08:30:46Z CONTRIBUTOR

@keewis Thanks for looking into this and updating the PR! :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
780909179 https://github.com/pydata/xarray/pull/2905#issuecomment-780909179 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDc4MDkwOTE3OQ== keewis 14808389 2021-02-17T22:56:29Z 2021-02-17T22:56:29Z MEMBER

@blsqr, I'm sorry for taking so long to review this. I updated your PR so this should be ready for merging.

I'm not sure that Variable is wrapping this CustomValues thing properly though.

that turned out not to be true, we can't wrap it in a list because then as_compatible_data wouldn't be able to find .values. Instead, Variable(dims=(), data=array) (or converting it to a duckarray) is the way to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
560127829 https://github.com/pydata/xarray/pull/2905#issuecomment-560127829 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDU2MDEyNzgyOQ== dcherian 2448579 2019-12-01T16:28:00Z 2019-12-01T16:28:00Z MEMBER

I'm not sure that Variable is wrapping this CustomValues thing properly though. Someone else will need to chime in.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
560127740 https://github.com/pydata/xarray/pull/2905#issuecomment-560127740 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDU2MDEyNzc0MA== dcherian 2448579 2019-12-01T16:27:22Z 2019-12-01T16:27:22Z MEMBER

We can ignore that for now. 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
560126145 https://github.com/pydata/xarray/pull/2905#issuecomment-560126145 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDU2MDEyNjE0NQ== blsqr 1700203 2019-12-01T16:13:22Z 2019-12-01T16:13:49Z CONTRIBUTOR

@dcherian The most recent pipeline now fails in the TestRasterio.test_rasterio_vrt test. This seems unrelated... but I'm not sure if they might be connected.

Could you give me a hint on how to continue? Or need this be fixed elsewhere (or is already fixed) and I need to update this topic branch?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
484275274 https://github.com/pydata/xarray/pull/2905#issuecomment-484275274 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDQ4NDI3NTI3NA== pep8speaks 24736507 2019-04-17T21:52:41Z 2019-12-01T15:58:23Z NONE

Hello @blsqr! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-12-01 15:58:23 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234
529125790 https://github.com/pydata/xarray/pull/2905#issuecomment-529125790 https://api.github.com/repos/pydata/xarray/issues/2905 MDEyOklzc3VlQ29tbWVudDUyOTEyNTc5MA== dcherian 2448579 2019-09-07T16:59:00Z 2019-09-07T16:59:00Z MEMBER

Thanks @blsqr. The tests are failing at this line: orig = Variable(dims=('x'), data=array, attrs={'foo': 'bar'})

so your change isn't working yet. Can you fix it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use explicit type check in `as_compatible_data` instead of blanket access to `values` attribute 434502234

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);