issue_comments: 780909179

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2905#issuecomment-780909179 https://api.github.com/repos/pydata/xarray/issues/2905 780909179 MDEyOklzc3VlQ29tbWVudDc4MDkwOTE3OQ== 14808389 2021-02-17T22:56:29Z 2021-02-17T22:56:29Z MEMBER

@blsqr, I'm sorry for taking so long to review this. I updated your PR so this should be ready for merging.

I'm not sure that Variable is wrapping this CustomValues thing properly though.

that turned out not to be true, we can't wrap it in a list because then as_compatible_data wouldn't be able to find .values. Instead, Variable(dims=(), data=array) (or converting it to a duckarray) is the way to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   434502234