issue_comments

Table actions

5 rows where issue = 428374352 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • BUG: Fix #2864 by adding the missing vrt parameters · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
482185568 https://github.com/pydata/xarray/pull/2865#issuecomment-482185568 https://api.github.com/repos/pydata/xarray/issues/2865 MDEyOklzc3VlQ29tbWVudDQ4MjE4NTU2OA== dcherian 2448579 2019-04-11T16:24:17Z 2019-04-11T16:24:17Z MEMBER

Thanks @jmichel-otb 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Fix #2864 by adding the missing vrt parameters 428374352
479927296 https://github.com/pydata/xarray/pull/2865#issuecomment-479927296 https://api.github.com/repos/pydata/xarray/issues/2865 MDEyOklzc3VlQ29tbWVudDQ3OTkyNzI5Ng== scottyhq 3924836 2019-04-04T14:45:01Z 2019-04-04T14:45:01Z MEMBER

@jmichel-otb completely agree on your comments and think that the remote sensing community gains a lot by making these packages work well together (gdal, rasterio, xarray, dask, etc). As more people start using the rasterio backend with various use cases hopefully there will be more contributions such as this. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Fix #2864 by adding the missing vrt parameters 428374352
479815045 https://github.com/pydata/xarray/pull/2865#issuecomment-479815045 https://api.github.com/repos/pydata/xarray/issues/2865 MDEyOklzc3VlQ29tbWVudDQ3OTgxNTA0NQ== pep8speaks 24736507 2019-04-04T09:06:31Z 2019-04-04T09:40:50Z NONE

Hello @jmichel-otb! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-04 09:40:50 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Fix #2864 by adding the missing vrt parameters 428374352
479822234 https://github.com/pydata/xarray/pull/2865#issuecomment-479822234 https://api.github.com/repos/pydata/xarray/issues/2865 MDEyOklzc3VlQ29tbWVudDQ3OTgyMjIzNA== jmichel-otb 10595679 2019-04-04T09:26:56Z 2019-04-04T09:26:56Z CONTRIBUTOR

@fmaussion done, let's see what CI has to say about my patches ;)

I remember reading a thread somewhere on xarray github repo discussing whether xarray should include the rasterio backend or not.

I understand that bridges between two libraries are always hard to maintain, because you need to know both products (we actually have the same kind of problem with OTB and QGis), but from a user standpoint, they need to exist somewhere. I would probably never have turned to xarray if someone with the required knowledge had not implemented the rasterio backend.

Then of course the user community should take care of maintaining those backends (this is what I am doing right now).

Bridging xarray with rasterio opens xarray to the remote sensing imagery community. And behind rasterio there is gdal, which is an awesome library with so many great capabilities (like this on-the-fly reprojection during reading I mentioned).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Fix #2864 by adding the missing vrt parameters 428374352
479381445 https://github.com/pydata/xarray/pull/2865#issuecomment-479381445 https://api.github.com/repos/pydata/xarray/issues/2865 MDEyOklzc3VlQ29tbWVudDQ3OTM4MTQ0NQ== fmaussion 10050469 2019-04-03T07:57:48Z 2019-04-03T07:57:48Z MEMBER

Should I add tests for this ?

If there is a way, it would be great yes. You can build upon (or adapt) this example here:

https://github.com/pydata/xarray/blob/225868d232219440b188956531d5764ff4cd1b53/xarray/tests/test_backends.py#L3327-L3351

cc @scottyhq who wrote this code, as I don't think any of the xarray team uses this format.

Please also add a line to whats-new.rst

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   BUG: Fix #2864 by adding the missing vrt parameters 428374352

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);