home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 479381445

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2865#issuecomment-479381445 https://api.github.com/repos/pydata/xarray/issues/2865 479381445 MDEyOklzc3VlQ29tbWVudDQ3OTM4MTQ0NQ== 10050469 2019-04-03T07:57:48Z 2019-04-03T07:57:48Z MEMBER

Should I add tests for this ?

If there is a way, it would be great yes. You can build upon (or adapt) this example here:

https://github.com/pydata/xarray/blob/225868d232219440b188956531d5764ff4cd1b53/xarray/tests/test_backends.py#L3327-L3351

cc @scottyhq who wrote this code, as I don't think any of the xarray team uses this format.

Please also add a line to whats-new.rst

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  428374352
Powered by Datasette · Queries took 0.873ms · About: xarray-datasette