issue_comments

Table actions

8 rows where issue = 423471477 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Enable python 3.5.0-3.5.2 · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
475474115 https://github.com/pydata/xarray/pull/2831#issuecomment-475474115 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTQ3NDExNQ== max-sixty 5635139 2019-03-22T02:40:18Z 2019-03-22T02:40:18Z MEMBER

I pushed a small change to put a single TYPE_CHECKING variable in pycompat, so we can simply the check that we put in each file.

Much nicer!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477
475086090 https://github.com/pydata/xarray/pull/2831#issuecomment-475086090 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTA4NjA5MA== pep8speaks 24736507 2019-03-21T01:23:38Z 2019-03-22T02:38:09Z NONE

Hello @max-sixty! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-03-22 02:38:08 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477
475462104 https://github.com/pydata/xarray/pull/2831#issuecomment-475462104 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTQ2MjEwNA== shoyer 1217238 2019-03-22T01:27:40Z 2019-03-22T01:27:40Z MEMBER

This looks good to me. I tested it locally and it works with mypy.

I pushed a small change to put a single TYPE_CHECKING variable in pycompat, so we can simply the check that we put in each file.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477
475265759 https://github.com/pydata/xarray/pull/2831#issuecomment-475265759 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTI2NTc1OQ== max-sixty 5635139 2019-03-21T15:02:14Z 2019-03-21T15:02:14Z MEMBER

Please could someone else take a final check and merge? @shoyer reviewed but not since some changes. Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477
475093182 https://github.com/pydata/xarray/pull/2831#issuecomment-475093182 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTA5MzE4Mg== max-sixty 5635139 2019-03-21T02:16:24Z 2019-03-21T02:16:24Z MEMBER

Green! Good idea re the single line, thanks @shoyer 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477
475062575 https://github.com/pydata/xarray/pull/2831#issuecomment-475062575 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTA2MjU3NQ== max-sixty 5635139 2019-03-20T23:05:45Z 2019-03-20T23:05:45Z MEMBER

I added a fix; it may have some mistakes which I'll correct

Is the approach OK? It's not pretty

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477
475058360 https://github.com/pydata/xarray/pull/2831#issuecomment-475058360 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTA1ODM2MA== max-sixty 5635139 2019-03-20T22:46:56Z 2019-03-20T22:46:56Z MEMBER

From #2830:

Probably the simplest thing to do would be to guard the import in a typing.TYPE_CHECKING block

Unfortunately that's only supported from 3.5.2!

I'll add a version check. I think there are only two places, and it won't last long

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477
475027811 https://github.com/pydata/xarray/pull/2831#issuecomment-475027811 https://api.github.com/repos/pydata/xarray/issues/2831 MDEyOklzc3VlQ29tbWVudDQ3NTAyNzgxMQ== max-sixty 5635139 2019-03-20T21:04:56Z 2019-03-20T21:56:05Z MEMBER

~TBC, I don't think this would allow 3.5.2 to work from PyPI even if we did a point release - 3.5.2 would still run 0.12.0~

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable python 3.5.0-3.5.2 423471477

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);