home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 475462104

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2831#issuecomment-475462104 https://api.github.com/repos/pydata/xarray/issues/2831 475462104 MDEyOklzc3VlQ29tbWVudDQ3NTQ2MjEwNA== 1217238 2019-03-22T01:27:40Z 2019-03-22T01:27:40Z MEMBER

This looks good to me. I tested it locally and it works with mypy.

I pushed a small change to put a single TYPE_CHECKING variable in pycompat, so we can simply the check that we put in each file.

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  423471477
Powered by Datasette · Queries took 0.46ms · About: xarray-datasette