issue_comments

Table actions

4 rows where issue = 403971686 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • [discussion] Use WKT or PROJ.4 string for CRS representation? · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
458332803 https://github.com/pydata/xarray/issues/2722#issuecomment-458332803 https://api.github.com/repos/pydata/xarray/issues/2722 MDEyOklzc3VlQ29tbWVudDQ1ODMzMjgwMw== snowman2 8699967 2019-01-28T22:45:52Z 2019-01-28T22:45:52Z CONTRIBUTOR

Since the main discussion is resolved, I will close this issue to prevent spam. I will open another issue for implementation details later.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [discussion] Use WKT or PROJ.4 string for CRS representation? 403971686
458322962 https://github.com/pydata/xarray/issues/2722#issuecomment-458322962 https://api.github.com/repos/pydata/xarray/issues/2722 MDEyOklzc3VlQ29tbWVudDQ1ODMyMjk2Mg== snowman2 8699967 2019-01-28T22:13:26Z 2019-01-28T22:13:26Z CONTRIBUTOR

Sounds like a good path forward to me.

Since the crs attribute will be deprecated, thoughts on replacing it with a crs coordinate and the PROJ.4 and WKT representations in the coordinate attributes?

Something like: <xarray.DataArray 'crs' ()> array(0) Coordinates: crs int64 0 Attributes: crs_wkt: PROJCS["UTM Zone 15, Northern Hemisphere",GEOGCS["WGS 84",D... crs_proj4: +proj=...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [discussion] Use WKT or PROJ.4 string for CRS representation? 403971686
458314851 https://github.com/pydata/xarray/issues/2722#issuecomment-458314851 https://api.github.com/repos/pydata/xarray/issues/2722 MDEyOklzc3VlQ29tbWVudDQ1ODMxNDg1MQ== djhoese 1828519 2019-01-28T21:48:30Z 2019-01-28T21:48:30Z CONTRIBUTOR

@fmaussion I like the idea of the proj4_crs and wkt_crs attributes. In the future I would hope the geoxarray package could handle this type of stuff (some day I'll get to it).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [discussion] Use WKT or PROJ.4 string for CRS representation? 403971686
458313603 https://github.com/pydata/xarray/issues/2722#issuecomment-458313603 https://api.github.com/repos/pydata/xarray/issues/2722 MDEyOklzc3VlQ29tbWVudDQ1ODMxMzYwMw== fmaussion 10050469 2019-01-28T21:44:36Z 2019-01-28T21:44:36Z MEMBER

Thanks @snowman2 ! I don't think there is much discussion necessary about whether we should use WKT or not, the question is rather how? WKT strings are quite complex and verbose, but this should not be a big issue.

We used proj4 strings in xarray because it's what rasterio's to_string would give us back, and we need a canonical string representation for serialization to netCDF. I don't know how many users rely on the rasterio backend's crs attribute to be a proj4 string, but I guess that it's at least a few.

So, what should we do? My preferred solution right now would be to deprecate the crs attribute and replace it with two explicit proj4_crs and wkt_crs attributes to cover all use cases.

Thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   [discussion] Use WKT or PROJ.4 string for CRS representation? 403971686

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);