home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 458313603

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2722#issuecomment-458313603 https://api.github.com/repos/pydata/xarray/issues/2722 458313603 MDEyOklzc3VlQ29tbWVudDQ1ODMxMzYwMw== 10050469 2019-01-28T21:44:36Z 2019-01-28T21:44:36Z MEMBER

Thanks @snowman2 ! I don't think there is much discussion necessary about whether we should use WKT or not, the question is rather how? WKT strings are quite complex and verbose, but this should not be a big issue.

We used proj4 strings in xarray because it's what rasterio's to_string would give us back, and we need a canonical string representation for serialization to netCDF. I don't know how many users rely on the rasterio backend's crs attribute to be a proj4 string, but I guess that it's at least a few.

So, what should we do? My preferred solution right now would be to deprecate the crs attribute and replace it with two explicit proj4_crs and wkt_crs attributes to cover all use cases.

Thoughts?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  403971686
Powered by Datasette · Queries took 1.535ms · About: xarray-datasette