issue_comments

Table actions

3 rows where issue = 399164733 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • max-sixty · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
455273458 https://github.com/pydata/xarray/pull/2674#issuecomment-455273458 https://api.github.com/repos/pydata/xarray/issues/2674 MDEyOklzc3VlQ29tbWVudDQ1NTI3MzQ1OA== max-sixty 5635139 2019-01-17T18:15:09Z 2019-01-17T18:15:09Z MEMBER

Is there a next step for a function which: - Is a drop-in replacement for .reduce - Similar to https://github.com/pydata/xarray/issues/1618, though maybe even simpler, i.e. only operates on a single input at first - Wraps apply_ufunc - Would restore dim order https://github.com/pydata/xarray/issues/1739 - Could be used by @fujiisoup 's recent functions, ref https://github.com/pydata/xarray/pull/2650#issuecomment-454164295 (though some of these may require multiple inputs, even though there's only one output?)

I'd be happy to give this a go if we agree on the broad design

For names, it's a shame the current apply isn't called map, and this could be apply. I'm not a great fan of apply_raw, since I'm can't yet see why it's any more 'raw'. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Skipping variables in datasets that don't have the core dim 399164733
455269655 https://github.com/pydata/xarray/pull/2674#issuecomment-455269655 https://api.github.com/repos/pydata/xarray/issues/2674 MDEyOklzc3VlQ29tbWVudDQ1NTI2OTY1NQ== max-sixty 5635139 2019-01-17T18:03:04Z 2019-01-17T18:03:04Z MEMBER

It's probably worth thinking about these APIs more systematically, see #1618, #1251, #1130

Nice, thanks for finding those

It might also be clearer to split this functionality into two methods rather than the single reduce() method, e.g., reduce() and transform() in the model of pandas's groupby methods.

Is the split needed? I had thought that the function either - returned a reduced array, and the output dims should be reduced - returned an array with the original dims, and then output dims shouldn't be reduced

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Skipping variables in datasets that don't have the core dim 399164733
454387095 https://github.com/pydata/xarray/pull/2674#issuecomment-454387095 https://api.github.com/repos/pydata/xarray/issues/2674 MDEyOklzc3VlQ29tbWVudDQ1NDM4NzA5NQ== max-sixty 5635139 2019-01-15T13:12:00Z 2019-01-15T13:12:00Z MEMBER

Thanks a lot for the comments @shoyer , that's v clarifying

Is there a conceptual overlap between the goals of .reduce and apply_ufunc? I had initially thought that .reduce strictly reduced a dimension, though that's not actually the case given cumsum

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Skipping variables in datasets that don't have the core dim 399164733

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);