issue_comments: 455269655

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2674#issuecomment-455269655 https://api.github.com/repos/pydata/xarray/issues/2674 455269655 MDEyOklzc3VlQ29tbWVudDQ1NTI2OTY1NQ== 5635139 2019-01-17T18:03:04Z 2019-01-17T18:03:04Z MEMBER

It's probably worth thinking about these APIs more systematically, see #1618, #1251, #1130

Nice, thanks for finding those

It might also be clearer to split this functionality into two methods rather than the single reduce() method, e.g., reduce() and transform() in the model of pandas's groupby methods.

Is the split needed? I had thought that the function either - returned a reduced array, and the output dims should be reduced - returned an array with the original dims, and then output dims shouldn't be reduced

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   399164733