issue_comments

Table actions

2 rows where issue = 396241341 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Type checking with mypy · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
452188208 https://github.com/pydata/xarray/pull/2655#issuecomment-452188208 https://api.github.com/repos/pydata/xarray/issues/2655 MDEyOklzc3VlQ29tbWVudDQ1MjE4ODIwOA== shoyer 1217238 2019-01-08T06:18:10Z 2019-01-08T06:18:10Z MEMBER

I think this is good to merge now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type checking with mypy 396241341
451776836 https://github.com/pydata/xarray/pull/2655#issuecomment-451776836 https://api.github.com/repos/pydata/xarray/issues/2655 MDEyOklzc3VlQ29tbWVudDQ1MTc3NjgzNg== shoyer 1217238 2019-01-06T21:32:46Z 2019-01-06T21:32:46Z MEMBER

I agree, let's experiment with keeping mypy optional for now. The error messages can definitely be a little confusing for non-experts. It should be pretty easy to fix regressions as they come up.

I've added a brief note on mypy to the contributing docs and removed the Travis-CI check.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Type checking with mypy 396241341

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);