issues: 396241341
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 396241341 | MDExOlB1bGxSZXF1ZXN0MjQyNDgzOTQx | 2655 | Type checking with mypy | 1217238 | closed | 0 | 4 | 2019-01-06T09:08:11Z | 2019-01-08T07:21:41Z | 2019-01-08T07:21:41Z | MEMBER | 0 | pydata/xarray/pulls/2655 | The rest of the scientific Python stack doesn't seem to support type annotations yet, but that's OK -- we can use this incrementally in xarray when it seems appropriate, and may check a few bugs. I'm especially excited to use this for internal functions, where we don't always bother with full docstrings (e.g., what is the type of the This includes: 1. various minor fixes to ensure that "mypy xarray" passes. 2. ~~adding "mypy xarray" to our lint check on Travis-CI.~~ For reference, see "Using mypy with an existing codebase": https://mypy.readthedocs.io/en/stable/existing_code.html Question: are we OK with (2)? This means Travis-CI will fail if your code causes mypy to error. |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/2655/reactions",
"total_count": 1,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 1,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |