issue_comments

Table actions

5 rows where issue = 395431629 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Remove py2 compat · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
457634142 https://github.com/pydata/xarray/pull/2645#issuecomment-457634142 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzYzNDE0Mg== shoyer 1217238 2019-01-25T16:38:56Z 2019-01-25T16:38:56Z MEMBER

thanks @jhamman !

 
{
    "total_count": 5,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 5,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457428509 https://github.com/pydata/xarray/pull/2645#issuecomment-457428509 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzQyODUwOQ== shoyer 1217238 2019-01-25T02:01:45Z 2019-01-25T02:01:45Z MEMBER

I found a couple of minor issues, otherwise it looks good!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457272478 https://github.com/pydata/xarray/pull/2645#issuecomment-457272478 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzI3MjQ3OA== shoyer 1217238 2019-01-24T16:56:07Z 2019-01-24T16:56:07Z MEMBER

See https://github.com/pydata/xarray/pull/2704 for a PR with release notes for 0.11.3. But I agree, there should be nothing stopping this from being merged now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457262680 https://github.com/pydata/xarray/pull/2645#issuecomment-457262680 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzI2MjY4MA== shoyer 1217238 2019-01-24T16:31:00Z 2019-01-24T16:31:00Z MEMBER

Let me try doing the backports now...

On Thu, Jan 24, 2019 at 8:24 AM Joe Hamman notifications@github.com wrote:

I think we should issue a back-port bug fix (0.11.3) and then merge this asap. The two issues @shoyer https://github.com/shoyer referenced above have been merged so, as far as I understand, there is nothing blocking the bugfix release at this point.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2645#issuecomment-457260100, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1lue5vxFptUYqKc5r_iKZLZcFi7oks5vGd44gaJpZM4Znc68 . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
451777938 https://github.com/pydata/xarray/pull/2645#issuecomment-451777938 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1MTc3NzkzOA== shoyer 1217238 2019-01-06T21:47:05Z 2019-01-06T21:47:05Z MEMBER

I think we should wait for a few weeks. There are two regressions that were recently fixed and that we may want to back-port: https://github.com/pydata/xarray/pull/2648 and https://github.com/pydata/xarray/pull/2651.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);