issue_comments

Table actions

14 rows where issue = 395431629 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Remove py2 compat · 14 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
457634142 https://github.com/pydata/xarray/pull/2645#issuecomment-457634142 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzYzNDE0Mg== shoyer 1217238 2019-01-25T16:38:56Z 2019-01-25T16:38:56Z MEMBER

thanks @jhamman !

 
{
    "total_count": 5,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 5,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457428509 https://github.com/pydata/xarray/pull/2645#issuecomment-457428509 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzQyODUwOQ== shoyer 1217238 2019-01-25T02:01:45Z 2019-01-25T02:01:45Z MEMBER

I found a couple of minor issues, otherwise it looks good!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457426308 https://github.com/pydata/xarray/pull/2645#issuecomment-457426308 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzQyNjMwOA== jhamman 2443309 2019-01-25T01:49:42Z 2019-01-25T01:49:42Z MEMBER

I plan to merge this tomorrow unless I hear otherwise. 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Remove py2 compat 395431629
457351536 https://github.com/pydata/xarray/pull/2645#issuecomment-457351536 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzM1MTUzNg== dcherian 2448579 2019-01-24T20:51:05Z 2019-01-24T20:51:05Z MEMBER

Also see #2574 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457275242 https://github.com/pydata/xarray/pull/2645#issuecomment-457275242 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzI3NTI0Mg== jhamman 2443309 2019-01-24T17:03:24Z 2019-01-24T17:03:24Z MEMBER

I'll sort out the conflicts today and get this merged ASAP.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457272478 https://github.com/pydata/xarray/pull/2645#issuecomment-457272478 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzI3MjQ3OA== shoyer 1217238 2019-01-24T16:56:07Z 2019-01-24T16:56:07Z MEMBER

See https://github.com/pydata/xarray/pull/2704 for a PR with release notes for 0.11.3. But I agree, there should be nothing stopping this from being merged now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457262680 https://github.com/pydata/xarray/pull/2645#issuecomment-457262680 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzI2MjY4MA== shoyer 1217238 2019-01-24T16:31:00Z 2019-01-24T16:31:00Z MEMBER

Let me try doing the backports now...

On Thu, Jan 24, 2019 at 8:24 AM Joe Hamman notifications@github.com wrote:

I think we should issue a back-port bug fix (0.11.3) and then merge this asap. The two issues @shoyer https://github.com/shoyer referenced above have been merged so, as far as I understand, there is nothing blocking the bugfix release at this point.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2645#issuecomment-457260100, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1lue5vxFptUYqKc5r_iKZLZcFi7oks5vGd44gaJpZM4Znc68 . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457260100 https://github.com/pydata/xarray/pull/2645#issuecomment-457260100 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzI2MDEwMA== jhamman 2443309 2019-01-24T16:24:23Z 2019-01-24T16:24:23Z MEMBER

I think we should issue a back-port bug fix (0.11.3) and then merge this asap. The two issues @shoyer referenced above have been merged so, as far as I understand, there is nothing blocking the bugfix release at this point. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
457257547 https://github.com/pydata/xarray/pull/2645#issuecomment-457257547 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1NzI1NzU0Nw== max-sixty 5635139 2019-01-24T16:17:52Z 2019-01-24T16:17:52Z MEMBER

What are our thoughts on merging this? I am sensitive that merge conflicts are growing

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
451777938 https://github.com/pydata/xarray/pull/2645#issuecomment-451777938 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1MTc3NzkzOA== shoyer 1217238 2019-01-06T21:47:05Z 2019-01-06T21:47:05Z MEMBER

I think we should wait for a few weeks. There are two regressions that were recently fixed and that we may want to back-port: https://github.com/pydata/xarray/pull/2648 and https://github.com/pydata/xarray/pull/2651.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
451777140 https://github.com/pydata/xarray/pull/2645#issuecomment-451777140 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1MTc3NzE0MA== jhamman 2443309 2019-01-06T21:36:51Z 2019-01-06T21:36:51Z MEMBER

@shoyer - at this point, do you anticipate another bug-fix release for 0.11? If not, I'm now leaning toward merging this to avoid too many merge conflicts. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
451326753 https://github.com/pydata/xarray/pull/2645#issuecomment-451326753 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1MTMyNjc1Mw== jhamman 2443309 2019-01-04T01:00:54Z 2019-01-04T01:00:54Z MEMBER

@fmaussion - you've articulated why I expected some friction here. I'm happy to hold off on this until we're sure 0.11 is clear of nasty bugs. @shoyer just went through the back-porting process so maybe he can comment on his appetite for dealing with this sort of thing. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
451243718 https://github.com/pydata/xarray/pull/2645#issuecomment-451243718 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1MTI0MzcxOA== fmaussion 10050469 2019-01-03T19:03:29Z 2019-01-03T19:03:29Z MEMBER

I expect some will feel its too soon to merge this

I never wrote py2 code myself so I don't think I'm of the "conservative" type, but I wonder if this PR will make it harder to provide bugfix cherry-picks on the hypothetical py2 compatible 0.11.x branch? Or do we want to ditch this possibility right away and simply focus on the bright py3-only future?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629
451231490 https://github.com/pydata/xarray/pull/2645#issuecomment-451231490 https://api.github.com/repos/pydata/xarray/issues/2645 MDEyOklzc3VlQ29tbWVudDQ1MTIzMTQ5MA== jhamman 2443309 2019-01-03T18:21:31Z 2019-01-03T18:21:31Z MEMBER

Was I not ambition enough 😉? It's only January 3 after all. I was really trying not to over do it.

Anyhow, I'm happy to include the future and unicode removals here. 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 1,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove py2 compat 395431629

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);