issue_comments

Closed via #2632

Let's add a build check of some sort for flake8, maybe to use alongside pep8speaks?

Down a level: # flake8: noqa skips a whole file when placed on its own line. # noqa skips a line when placed at the end of the line. I saw a few of the former attempting to do the latter

s strict pep8 compliance supposed to be mandatory in xarray? Sometimes it makes more sense to violate PEP8 to improve readability.

My vote is: - Strict compliance isn't that important, and secondary to readability - Standards, supported by automated checks, ease collaborating and scaling

...so by-and-large do whatever you think is best, but make the checks pass with a comment where the code violates a standard

We do aim for strict PEP8 compliance, but this is hard to enforce without the automated checks. Cases where it's violated intentionally can be marked with a comment.

@max-sixty Is strict pep8 compliance supposed to be mandatory in xarray? Sometimes it makes more sense to violate PEP8 to improve readability. My PR #2553 has some examples - e.g. here where I deliberately used a longer line rather than two lines so that it was clearer that I was testing what happens when you concatenate a square of 4 datasets. On the other hand there are also some violations of pep8 in the PR which are just oversights, and did get lost in the (lengthy) discussion.

Is strict pep8 compliance already supposed to be mandatory in xarray? Should any intentional pep8 violations be flagged using # noqa so that flake8 ignores that line?

OK great - I've PRed changes to get back to zero

It would be good if pep8speaks added a check too, but looks like it's not available. We could either: - Add one to travis - Look into Stickler? (It looks online and active, but potentially we had a bad experience last time?) - No system changes, but reviewers are more attentive to the initial pep8speaks comment

I think I need to be more careful to check the first comment for PEP8 issues before merging -- I've been relying on the green checkmarks.

@max-sixty Pep8speaks edits his first comment for every push (he looks testing) probably to avoid adding too many comments to the thread. But it is now easy to review the pep8 violation if the thread becomes large.

Personally, I feel it is not the best solution for the smooth development. If you have an alternative in your mind and could set it up, it'll be super nice.