home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 449738704

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2627#issuecomment-449738704 https://api.github.com/repos/pydata/xarray/issues/2627 449738704 MDEyOklzc3VlQ29tbWVudDQ0OTczODcwNA== 35968931 2018-12-24T14:11:13Z 2018-12-24T14:11:13Z MEMBER

@max-sixty Is strict pep8 compliance supposed to be mandatory in xarray? Sometimes it makes more sense to violate PEP8 to improve readability. My PR #2553 has some examples - e.g. here where I deliberately used a longer line rather than two lines so that it was clearer that I was testing what happens when you concatenate a square of 4 datasets. On the other hand there are also some violations of pep8 in the PR which are just oversights, and did get lost in the (lengthy) discussion.

Is strict pep8 compliance already supposed to be mandatory in xarray? Should any intentional pep8 violations be flagged using # noqa so that flake8 ignores that line?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  393710539
Powered by Datasette · Queries took 1.246ms · About: xarray-datasette