issue_comments

Table actions

4 rows where issue = 379177627 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fmaussion · 4 ✖

issue 1

  • HDF Errors since xarray 0.11 · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
437707951 https://github.com/pydata/xarray/issues/2551#issuecomment-437707951 https://api.github.com/repos/pydata/xarray/issues/2551 MDEyOklzc3VlQ29tbWVudDQzNzcwNzk1MQ== fmaussion 10050469 2018-11-11T21:46:02Z 2018-11-11T21:46:02Z MEMBER

but now operates lazily.

If so, how does the dataset access the data if the file is closed? Shouldn't it raise an error instead?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   HDF Errors since xarray 0.11 379177627
437705060 https://github.com/pydata/xarray/issues/2551#issuecomment-437705060 https://api.github.com/repos/pydata/xarray/issues/2551 MDEyOklzc3VlQ29tbWVudDQzNzcwNTA2MA== fmaussion 10050469 2018-11-11T21:08:13Z 2018-11-11T21:08:13Z MEMBER

Actually I have to ask: why is it possible to to an operation on a closed dataset? What is happening under the hood which creates this error and wasn't earlier?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   HDF Errors since xarray 0.11 379177627
437664983 https://github.com/pydata/xarray/issues/2551#issuecomment-437664983 https://api.github.com/repos/pydata/xarray/issues/2551 MDEyOklzc3VlQ29tbWVudDQzNzY2NDk4Mw== fmaussion 10050469 2018-11-11T12:10:36Z 2018-11-11T12:10:36Z MEMBER

Yep, that looks a bug on your end. Were you using autoclose=True before?

No, the exact same piece of code works without error with xarray prev 0.11. Closing this now!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   HDF Errors since xarray 0.11 379177627
437574599 https://github.com/pydata/xarray/issues/2551#issuecomment-437574599 https://api.github.com/repos/pydata/xarray/issues/2551 MDEyOklzc3VlQ29tbWVudDQzNzU3NDU5OQ== fmaussion 10050469 2018-11-10T10:39:09Z 2018-11-10T10:40:35Z MEMBER

I am slightly regretting not doing a release candidate here,

I should be better placed than anyone to anticipate and test more frequently on master :roll_eyes:

So this reproduces the problem on my machine and travis. Note the misplaced computation out of the with block:

```python import xarray as xr import numpy as np import netCDF4 import os

try: os.remove('test.nc') except OSError: pass

thick = np.zeros((180, 200), np.float32)

ds = xr.Dataset() ds['thick'] = (('y', 'x'), thick) ds.to_netcdf('test.nc')

with xr.open_dataset('test.nc') as ds: dummy = ds.thick.isel(x=('z', [1, 3, 4]), y=('z', [7, 2, 1]))

dummy.min() # this is the issue

with netCDF4.Dataset('test.nc', 'a') as nc: nc.variables['thick'][:] = thick
```

I guess this was actually a bug in our code, but for some reason it worked fine with earlier xarray versions. I'm not sure if this requires action on the xarray side in the end...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   HDF Errors since xarray 0.11 379177627

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);