issue_comments: 437574599

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/2551#issuecomment-437574599 https://api.github.com/repos/pydata/xarray/issues/2551 437574599 MDEyOklzc3VlQ29tbWVudDQzNzU3NDU5OQ== 10050469 2018-11-10T10:39:09Z 2018-11-10T10:40:35Z MEMBER

I am slightly regretting not doing a release candidate here,

I should be better placed than anyone to anticipate and test more frequently on master :roll_eyes:

So this reproduces the problem on my machine and travis. Note the misplaced computation out of the with block:

```python import xarray as xr import numpy as np import netCDF4 import os

try: os.remove('test.nc') except OSError: pass

thick = np.zeros((180, 200), np.float32)

ds = xr.Dataset() ds['thick'] = (('y', 'x'), thick) ds.to_netcdf('test.nc')

with xr.open_dataset('test.nc') as ds: dummy = ds.thick.isel(x=('z', [1, 3, 4]), y=('z', [7, 2, 1]))

dummy.min() # this is the issue

with netCDF4.Dataset('test.nc', 'a') as nc: nc.variables['thick'][:] = thick
```

I guess this was actually a bug in our code, but for some reason it worked fine with earlier xarray versions. I'm not sure if this requires action on the xarray side in the end...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   379177627