issue_comments

Table actions

2 rows where issue = 374434077 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association

user 1

  • shoyer · 2 ✖

issue 1

  • Switch enable_cftimeindex to True by default · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
434899873 https://github.com/pydata/xarray/pull/2516#issuecomment-434899873 https://api.github.com/repos/pydata/xarray/issues/2516 MDEyOklzc3VlQ29tbWVudDQzNDg5OTg3Mw== shoyer 1217238 2018-11-01T01:22:01Z 2018-11-01T01:22:01Z MEMBER

In 6d08d3b I made changes to set_options to only fill the self.old dictionary with the old values for the keyword arguments specified in the constructor, and then had the exit method only reset the values that were temporarily set before. The win-32 build now passes, and we no longer have the undesirable warning behavior shown above. Do you think that was a reasonable fix?

This looks like a reasonable fix to me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Switch enable_cftimeindex to True by default 374434077
434747673 https://github.com/pydata/xarray/pull/2516#issuecomment-434747673 https://api.github.com/repos/pydata/xarray/issues/2516 MDEyOklzc3VlQ29tbWVudDQzNDc0NzY3Mw== shoyer 1217238 2018-10-31T16:08:46Z 2018-10-31T16:08:46Z MEMBER

I don't know why this failed in one of the Appveyor builds: ``` ================================== FAILURES =================================== _____ test_enable_cftimeindex _______ def test_enable_cftimeindex(): with pytest.raises(ValueError): xarray.set_options(enable_cftimeindex=None) with pytest.warns(FutureWarning, match='no-op'): with xarray.set_options(enable_cftimeindex=True):

          assert OPTIONS['enable_cftimeindex']

E Failed: DID NOT WARN. No warnings of type (<type 'exceptions.FutureWarning'>,) was emitted. The list of emitted warnings is: []. xarray\tests\test_options.py:38: Failed ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Switch enable_cftimeindex to True by default 374434077

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);