issue_comments: 434899873

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2516#issuecomment-434899873 https://api.github.com/repos/pydata/xarray/issues/2516 434899873 MDEyOklzc3VlQ29tbWVudDQzNDg5OTg3Mw== 1217238 2018-11-01T01:22:01Z 2018-11-01T01:22:01Z MEMBER

In 6d08d3b I made changes to set_options to only fill the self.old dictionary with the old values for the keyword arguments specified in the constructor, and then had the exit method only reset the values that were temporarily set before. The win-32 build now passes, and we no longer have the undesirable warning behavior shown above. Do you think that was a reasonable fix?

This looks like a reasonable fix to me

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   374434077