issue_comments

Table actions

7 rows where issue = 372640063 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Avoid use of deprecated get= parameter in tests · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
432184231 https://github.com/pydata/xarray/pull/2500#issuecomment-432184231 https://api.github.com/repos/pydata/xarray/issues/2500 MDEyOklzc3VlQ29tbWVudDQzMjE4NDIzMQ== alexamici 226037 2018-10-23T10:06:20Z 2018-10-23T10:31:37Z MEMBER

@shoyer you are right, I had to make a user-visible backward-incompatible change in cfgrib and Travis is getting the latest version.

I'll make a PR to fix the test.

Note that I don't expect to do any other backward-incompatible change this big and the test is going to be robust to version change from now on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of deprecated get= parameter in tests 372640063
432037896 https://github.com/pydata/xarray/pull/2500#issuecomment-432037896 https://api.github.com/repos/pydata/xarray/issues/2500 MDEyOklzc3VlQ29tbWVudDQzMjAzNzg5Ng== shoyer 1217238 2018-10-23T00:22:56Z 2018-10-23T00:22:56Z MEMBER

thanks @mrocklin !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of deprecated get= parameter in tests 372640063
432037721 https://github.com/pydata/xarray/pull/2500#issuecomment-432037721 https://api.github.com/repos/pydata/xarray/issues/2500 MDEyOklzc3VlQ29tbWVudDQzMjAzNzcyMQ== shoyer 1217238 2018-10-23T00:22:01Z 2018-10-23T00:22:01Z MEMBER

I'm pretty sure that error is different, cc @alexamici 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of deprecated get= parameter in tests 372640063
432016733 https://github.com/pydata/xarray/pull/2500#issuecomment-432016733 https://api.github.com/repos/pydata/xarray/issues/2500 MDEyOklzc3VlQ29tbWVudDQzMjAxNjczMw== mrocklin 306380 2018-10-22T22:42:11Z 2018-10-22T22:42:11Z MEMBER

I'm not sure that I understand the failure here. Can someone verify that this is related to these changes?

``` =================================== FAILURES =================================== ____ TestCfGrib.test_read ____ self = <xarray.tests.test_backends.TestCfGrib object at 0x7fd47fc30b00> def test_read(self): expected = {'number': 2, 'time': 3, 'air_pressure': 2, 'latitude': 3, 'longitude': 4} with open_example_dataset('example.grib', engine='cfgrib') as ds:

      assert ds.dims == expected

E AssertionError: assert Frozen(Sorted...ngitude': 4})) == {'air_pressure...mber': 2, ...} E Full diff: E - Frozen(SortedKeysDict({'number': 2, 'time': 3, 'isobaricInhPa': 2, 'latitude': 3, 'longitude': 4})) E + {'air_pressure': 2, 'latitude': 3, 'longitude': 4, 'number': 2, 'time': 3} xarray/tests/test_backends.py:2473: AssertionError ___ TestCfGrib.test_read_filter_by_keys ____ self = <xarray.tests.test_backends.TestCfGrib object at 0x7fd4904b12b0> def test_read_filter_by_keys(self): kwargs = {'filter_by_keys': {'shortName': 't'}} expected = {'number': 2, 'time': 3, 'air_pressure': 2, 'latitude': 3, 'longitude': 4} with open_example_dataset('example.grib', engine='cfgrib', backend_kwargs=kwargs) as ds: assert ds.dims == expected E AssertionError: assert Frozen(Sorted...ngitude': 4})) == {'air_pressure...mber': 2, ...} E Full diff: E - Frozen(SortedKeysDict({'number': 2, 'time': 3, 'isobaricInhPa': 2, 'latitude': 3, 'longitude': 4})) E + {'air_pressure': 2, 'latitude': 3, 'longitude': 4, 'number': 2, 'time': 3} xarray/tests/test_backends.py:2483: AssertionError ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of deprecated get= parameter in tests 372640063
431963883 https://github.com/pydata/xarray/pull/2500#issuecomment-431963883 https://api.github.com/repos/pydata/xarray/issues/2500 MDEyOklzc3VlQ29tbWVudDQzMTk2Mzg4Mw== pep8speaks 24736507 2018-10-22T20:06:43Z 2018-10-22T20:06:43Z NONE

Hello @mrocklin! Thanks for submitting the PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of deprecated get= parameter in tests 372640063
431934087 https://github.com/pydata/xarray/pull/2500#issuecomment-431934087 https://api.github.com/repos/pydata/xarray/issues/2500 MDEyOklzc3VlQ29tbWVudDQzMTkzNDA4Nw== mrocklin 306380 2018-10-22T18:49:11Z 2018-10-22T18:49:11Z MEMBER

Yes, github is still having issues. https://status.github.com/messages

We are working through the backlogs of webhook deliveries and Pages builds. We continue to monitor as the site recovers.

On Mon, Oct 22, 2018 at 2:48 PM Maximilian Roos notifications@github.com wrote:

Thanks @mrocklin https://github.com/mrocklin

Anyone have any idea why Travis isn't running? Is it the GH issues from this morning? Looks like the latest run was a couple of days ago: https://travis-ci.org/pydata/xarray/pull_requests

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2500#issuecomment-431933524, or mute the thread https://github.com/notifications/unsubscribe-auth/AASszMBivzvQsiHHkWkGP2F2kYaafzmeks5unhLggaJpZM4Xz6dG . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of deprecated get= parameter in tests 372640063
431933524 https://github.com/pydata/xarray/pull/2500#issuecomment-431933524 https://api.github.com/repos/pydata/xarray/issues/2500 MDEyOklzc3VlQ29tbWVudDQzMTkzMzUyNA== max-sixty 5635139 2018-10-22T18:47:46Z 2018-10-22T18:47:46Z MEMBER

Thanks @mrocklin

Anyone have any idea why Travis isn't running? Is it the GH issues from this morning? Looks like the latest run was a couple of days ago: https://travis-ci.org/pydata/xarray/pull_requests

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Avoid use of deprecated get= parameter in tests 372640063

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);