issue_comments: 432016733

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2500#issuecomment-432016733 https://api.github.com/repos/pydata/xarray/issues/2500 432016733 MDEyOklzc3VlQ29tbWVudDQzMjAxNjczMw== 306380 2018-10-22T22:42:11Z 2018-10-22T22:42:11Z MEMBER

I'm not sure that I understand the failure here. Can someone verify that this is related to these changes?

``` =================================== FAILURES =================================== ____ TestCfGrib.test_read ____ self = <xarray.tests.test_backends.TestCfGrib object at 0x7fd47fc30b00> def test_read(self): expected = {'number': 2, 'time': 3, 'air_pressure': 2, 'latitude': 3, 'longitude': 4} with open_example_dataset('example.grib', engine='cfgrib') as ds:

      assert ds.dims == expected

E AssertionError: assert Frozen(Sorted...ngitude': 4})) == {'air_pressure...mber': 2, ...} E Full diff: E - Frozen(SortedKeysDict({'number': 2, 'time': 3, 'isobaricInhPa': 2, 'latitude': 3, 'longitude': 4})) E + {'air_pressure': 2, 'latitude': 3, 'longitude': 4, 'number': 2, 'time': 3} xarray/tests/test_backends.py:2473: AssertionError ___ TestCfGrib.test_read_filter_by_keys ____ self = <xarray.tests.test_backends.TestCfGrib object at 0x7fd4904b12b0> def test_read_filter_by_keys(self): kwargs = {'filter_by_keys': {'shortName': 't'}} expected = {'number': 2, 'time': 3, 'air_pressure': 2, 'latitude': 3, 'longitude': 4} with open_example_dataset('example.grib', engine='cfgrib', backend_kwargs=kwargs) as ds: assert ds.dims == expected E AssertionError: assert Frozen(Sorted...ngitude': 4})) == {'air_pressure...mber': 2, ...} E Full diff: E - Frozen(SortedKeysDict({'number': 2, 'time': 3, 'isobaricInhPa': 2, 'latitude': 3, 'longitude': 4})) E + {'air_pressure': 2, 'latitude': 3, 'longitude': 4, 'number': 2, 'time': 3} xarray/tests/test_backends.py:2483: AssertionError ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   372640063