issue_comments

Table actions

4 rows where issue = 368912226 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Fix backend test classes so they actually run · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
429126831 https://github.com/pydata/xarray/pull/2479#issuecomment-429126831 https://api.github.com/repos/pydata/xarray/issues/2479 MDEyOklzc3VlQ29tbWVudDQyOTEyNjgzMQ== max-sixty 5635139 2018-10-11T21:34:50Z 2018-10-11T21:34:50Z MEMBER

Thanks @shoyer !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix backend test classes so they actually run 368912226
429122765 https://github.com/pydata/xarray/pull/2479#issuecomment-429122765 https://api.github.com/repos/pydata/xarray/issues/2479 MDEyOklzc3VlQ29tbWVudDQyOTEyMjc2NQ== shoyer 1217238 2018-10-11T21:20:49Z 2018-10-11T21:20:49Z MEMBER

There's a real test failure with dask-dev, but it's unrelated.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix backend test classes so they actually run 368912226
428796152 https://github.com/pydata/xarray/pull/2479#issuecomment-428796152 https://api.github.com/repos/pydata/xarray/issues/2479 MDEyOklzc3VlQ29tbWVudDQyODc5NjE1Mg== max-sixty 5635139 2018-10-11T02:23:17Z 2018-10-11T02:23:17Z MEMBER

Good catch!

I'm sorry I missed this. I should have compared the total number of tests running given it was a broad change to the tests.

Here's a patch to make the current tests pass:

```diff diff --git a/xarray/tests/test_conventions.py b/xarray/tests/test_conventions.py index a067d01a..5fa518f5 100644 --- a/xarray/tests/test_conventions.py +++ b/xarray/tests/test_conventions.py @@ -18,7 +18,7 @@ from xarray.testing import assert_identical from . import ( assert_array_equal, raises_regex, requires_cftime_or_netCDF4, requires_dask, requires_netCDF4) -from .test_backends import CFEncodedDataTest +from .test_backends import CFEncodedBase

class TestBoolTypeArray(object): @@ -255,7 +255,7 @@ class CFEncodedInMemoryStore(WritableCFDataStore, InMemoryDataStore):

@requires_netCDF4 -class TestCFEncodedDataStore(CFEncodedDataTest): +class TestCFEncodedDataStore(CFEncodedBase): @contextlib.contextmanager def create_store(self): yield CFEncodedInMemoryStore() ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix backend test classes so they actually run 368912226
428783263 https://github.com/pydata/xarray/pull/2479#issuecomment-428783263 https://api.github.com/repos/pydata/xarray/issues/2479 MDEyOklzc3VlQ29tbWVudDQyODc4MzI2Mw== pep8speaks 24736507 2018-10-11T01:08:16Z 2018-10-11T01:08:16Z NONE

Hello @shoyer! Thanks for submitting the PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix backend test classes so they actually run 368912226

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);