issue_comments: 428796152
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/2479#issuecomment-428796152 | https://api.github.com/repos/pydata/xarray/issues/2479 | 428796152 | MDEyOklzc3VlQ29tbWVudDQyODc5NjE1Mg== | 5635139 | 2018-10-11T02:23:17Z | 2018-10-11T02:23:17Z | MEMBER | Good catch! I'm sorry I missed this. I should have compared the total number of tests running given it was a broad change to the tests. Here's a patch to make the current tests pass: ```diff diff --git a/xarray/tests/test_conventions.py b/xarray/tests/test_conventions.py index a067d01a..5fa518f5 100644 --- a/xarray/tests/test_conventions.py +++ b/xarray/tests/test_conventions.py @@ -18,7 +18,7 @@ from xarray.testing import assert_identical from . import ( assert_array_equal, raises_regex, requires_cftime_or_netCDF4, requires_dask, requires_netCDF4) -from .test_backends import CFEncodedDataTest +from .test_backends import CFEncodedBase class TestBoolTypeArray(object): @@ -255,7 +255,7 @@ class CFEncodedInMemoryStore(WritableCFDataStore, InMemoryDataStore): @requires_netCDF4 -class TestCFEncodedDataStore(CFEncodedDataTest): +class TestCFEncodedDataStore(CFEncodedBase): @contextlib.contextmanager def create_store(self): yield CFEncodedInMemoryStore() ``` |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
368912226 |