issue_comments

Table actions

6 rows where issue = 361818115 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • Plot2D no longer sorts coordinates before plotting · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
423615760 https://github.com/pydata/xarray/issues/2422#issuecomment-423615760 https://api.github.com/repos/pydata/xarray/issues/2422 MDEyOklzc3VlQ29tbWVudDQyMzYxNTc2MA== shoyer 1217238 2018-09-21T17:36:46Z 2018-09-21T17:36:46Z MEMBER

I think this is fixed by #2425?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot2D no longer sorts coordinates before plotting 361818115
423111183 https://github.com/pydata/xarray/issues/2422#issuecomment-423111183 https://api.github.com/repos/pydata/xarray/issues/2422 MDEyOklzc3VlQ29tbWVudDQyMzExMTE4Mw== fmaussion 10050469 2018-09-20T09:29:14Z 2018-09-20T09:29:28Z MEMBER

I cannot reproduce this with a dataset with decreasing latitude

Maybe a MPL version issue? Because our docs are also afffected, see: - http://xarray.pydata.org/en/stable/plotting.html#two-dimensions - http://xarray.pydata.org/en/latest/plotting.html#two-dimensions

@fmaussion I'd appreciate it if you could look at this

I will have a look now

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot2D no longer sorts coordinates before plotting 361818115
422979924 https://github.com/pydata/xarray/issues/2422#issuecomment-422979924 https://api.github.com/repos/pydata/xarray/issues/2422 MDEyOklzc3VlQ29tbWVudDQyMjk3OTkyNA== dcherian 2448579 2018-09-19T22:29:51Z 2018-09-19T22:29:51Z MEMBER

Yes #2294 changed the default xincrease, yincrease to be None rather than True. Previously, if xincrease was True we were setting axis limits and this prevented the axis from auto-updating its limits. Now that we are using the invert_axis() method, this might not be an issue. (Actually, now that I look at the code for invert_axis(), all I needed to do earlier was set the kwarg auto=None in the call to set_xlim, so this would be an easy way to revert to the previous code.)

I switched the default to None because I thought it was better to make the least number of modifications to the axis by default.

That said, I cannot reproduce this with a dataset with decreasing latitude so I'm very confused about what's happening. ``` da = xr.DataArray(np.arange(24).reshape(3,8), dims=('latitude', 'longitude'), coords={'latitude': [8, 0, -8], 'longitude': np.arange(8)})

da.plot() ```

PS: I'm on a ship in the middle of the Pacific with crappy internet access. @fmaussion I'd appreciate it if you could look at this so we can get the release out. I will respond but there'll be a large time lag.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot2D no longer sorts coordinates before plotting 361818115
422955254 https://github.com/pydata/xarray/issues/2422#issuecomment-422955254 https://api.github.com/repos/pydata/xarray/issues/2422 MDEyOklzc3VlQ29tbWVudDQyMjk1NTI1NA== fmaussion 10050469 2018-09-19T20:55:32Z 2018-09-19T20:55:32Z MEMBER

Looks like a difficult thing to test, also...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot2D no longer sorts coordinates before plotting 361818115
422947474 https://github.com/pydata/xarray/issues/2422#issuecomment-422947474 https://api.github.com/repos/pydata/xarray/issues/2422 MDEyOklzc3VlQ29tbWVudDQyMjk0NzQ3NA== shoyer 1217238 2018-09-19T20:30:25Z 2018-09-19T20:30:25Z MEMBER

The most likely source here is https://github.com/pydata/xarray/pull/2294

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot2D no longer sorts coordinates before plotting 361818115
422946035 https://github.com/pydata/xarray/issues/2422#issuecomment-422946035 https://api.github.com/repos/pydata/xarray/issues/2422 MDEyOklzc3VlQ29tbWVudDQyMjk0NjAzNQ== shoyer 1217238 2018-09-19T20:25:39Z 2018-09-19T20:25:39Z MEMBER

cc @dcherian 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plot2D no longer sorts coordinates before plotting 361818115

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);