issue_comments

Table actions

3 rows where issue = 357808970 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • WIP: don't create indexes on multidimensional dimensions · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
455825759 https://github.com/pydata/xarray/pull/2405#issuecomment-455825759 https://api.github.com/repos/pydata/xarray/issues/2405 MDEyOklzc3VlQ29tbWVudDQ1NTgyNTc1OQ== shoyer 1217238 2019-01-20T00:06:21Z 2019-01-20T00:06:21Z MEMBER

I think this function mostly makes sense, but we would want to drop the stuff for scalar variables.

Unfortunately I don't know a good way to fix this stuff short of auditing a lot of code manually -- this is a hazard of data model changes. On the plus side, I've also started to do some of this for the explicit index refactor.

One thing that might turn up a few bugs is to try adding such a variable to the create_test_data() helper function which gets used in lots of places.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: don't create indexes on multidimensional dimensions 357808970
419969570 https://github.com/pydata/xarray/pull/2405#issuecomment-419969570 https://api.github.com/repos/pydata/xarray/issues/2405 MDEyOklzc3VlQ29tbWVudDQxOTk2OTU3MA== shoyer 1217238 2018-09-10T16:10:27Z 2018-09-10T16:49:51Z MEMBER

It would be good to add a tests for these variables in: - The data_vars argument to the Dataset constructor (these objects should become data_vars, not coords) - The DataArray constructor. - Explicitly adding these variables: - With Dataset.__setitem__, Dataset.coords.__setitem__ and DataArray.coords.__setitem__ - When there are no existing variables matching the dimension name, and when a 1D index variable matching the dimension name already exists (the existing index should be deleted/cleared) - Converting these objects to pandas with to_dataframe, to_series and to_pandas - Concatenating along an existing dimension whose name matches existing variables (e.g., concatenate along x when a variable x with dimensions ('x', 'y') exists) - Concatenating along a new dimension whose name matches existing variables (e.g., concatenate along x when a variable x with dimensions ('y',) exists) - More generally, test variables where the name matches a dimension but the variable does not include that dimension at all, e.g., a variable 'x' with dimensions ('y',) in a Dataset where x is a dimension.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: don't create indexes on multidimensional dimensions 357808970
419960606 https://github.com/pydata/xarray/pull/2405#issuecomment-419960606 https://api.github.com/repos/pydata/xarray/issues/2405 MDEyOklzc3VlQ29tbWVudDQxOTk2MDYwNg== shoyer 1217238 2018-09-10T15:44:45Z 2018-09-10T15:44:45Z MEMBER

I turned up a few lines that probably need to be fixed, just by grepping for in\ \w+\.dims: https://github.com/pydata/xarray/blob/66a8f8dd7f5a2997ff614f3966d1951587915e7e/xarray/backends/api.py#L125-L126 https://github.com/pydata/xarray/blob/66a8f8dd7f5a2997ff614f3966d1951587915e7e/xarray/core/coordinates.py#L111-L116 https://github.com/pydata/xarray/blob/66a8f8dd7f5a2997ff614f3966d1951587915e7e/xarray/core/dataarray.py#L502

It looks like this change broke align somehow -- possibly we have a bug where some indexes were not being created as IndexVariable objects?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: don't create indexes on multidimensional dimensions 357808970

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);